fix(search): Store all bucket variants for duplicate app names

Previously [] stored a single path/bucket entry,
overwriting duplicates when the same app existed in multiple buckets.
If that bucket's file was later removed, the cache lookup failed
silently. Now stores an array of entries per app name, and
search_by_index iterates all variants. Also adds Write-Debug
diagnostics to previously empty catch blocks.

Author: B67687

libexec/scoop-search.ps1

@@ -39,7 +39,11 @@ function init_search_cache {
         if ($cache.maxWriteUtc -ne $currentMaxWrite.ToString('o')) { return $false }
         $script:searchIndexApps = @{}
         foreach ($prop in $cache.apps.PSObject.Properties) {
-            $script:searchIndexApps[$prop.Name] = @{ path = $prop.Value.path; bucket = $prop.Value.bucket }
+            $entries = @()
+            foreach ($entry in $prop.Value) {
+                $entries += @{ path = $entry.path; bucket = $entry.bucket }
+            }
+            $script:searchIndexApps[$prop.Name] = $entries
         }
         $script:searchIndexBins = @{}
         foreach ($prop in $cache.bins.PSObject.Properties) {
@@ -68,7 +72,8 @@ function build_search_cache {
     foreach ($bucket in $allPathsByBucket.Keys) {
         foreach ($filePath in $allPathsByBucket[$bucket]) {
             $appName = [System.IO.Path]::GetFileNameWithoutExtension($filePath)
-            $newApps[$appName] = @{ path = $filePath; bucket = $bucket }
+            if (-not $newApps.ContainsKey($appName)) { $newApps[$appName] = @() }
+            $newApps[$appName] += @{ path = $filePath; bucket = $bucket }
             try {
                 $manifest = Get-Content -Path $filePath -Raw | ConvertFrom-Json -ErrorAction Stop
                 if (-not $manifest.bin) { continue }
@@ -91,7 +96,7 @@ function build_search_cache {
                         }
                     }
                 }
-            } catch { }
+            } catch { Write-Debug "cache-build parse failed for $($filePath): $($_.Exception.Message)" }
         }
     }
     $cacheData = [PSCustomObject]@{ timestamp = (Get-Date).ToString('o'); fileCount = $totalCount; maxWriteUtc = $maxWriteUtc.ToString('o'); apps = [PSCustomObject]$newApps; bins = [PSCustomObject]$newBins }
@@ -120,29 +125,30 @@ function search_by_index($query) {
     }
     # Parse manifests only for matched apps
     foreach ($appName in $matched.Keys) {
-        $info = $searchIndexApps[$appName]
-        try {
-            $manifest = Get-Content -Path $info.path -Raw | ConvertFrom-Json -ErrorAction Stop
-            $binaries = ''
-            $binMatches = @()
-            if (-not $manifest) { continue }
-            if ($manifest.bin) {
-                foreach ($binEntry in $manifest.bin) {
-                    $exe = $null; $alias = $null
-                    if ($binEntry -is [System.Object[]]) {
-                        $exe = $binEntry[0]
-                        $alias = if ($binEntry.Count -gt 1) { $binEntry[1] } else { $null }
-                    } else { $exe = $binEntry }
-                    $exeName = [System.IO.Path]::GetFileNameWithoutExtension([string]$exe)
-                    if ($exeName.IndexOf($query, [StringComparison]::OrdinalIgnoreCase) -ge 0 -or
-                        ($alias -and $alias.IndexOf($query, [StringComparison]::OrdinalIgnoreCase) -ge 0)) {
-                        $binMatches += [System.IO.Path]::GetFileName([string]$exe)
+        foreach ($entry in $searchIndexApps[$appName]) {
+            try {
+                $manifest = Get-Content -Path $entry.path -Raw | ConvertFrom-Json -ErrorAction Stop
+                $binaries = ''
+                $binMatches = @()
+                if (-not $manifest) { continue }
+                if ($manifest.bin) {
+                    foreach ($binEntry in $manifest.bin) {
+                        $exe = $null; $alias = $null
+                        if ($binEntry -is [System.Object[]]) {
+                            $exe = $binEntry[0]
+                            $alias = if ($binEntry.Count -gt 1) { $binEntry[1] } else { $null }
+                        } else { $exe = $binEntry }
+                        $exeName = [System.IO.Path]::GetFileNameWithoutExtension([string]$exe)
+                        if ($exeName.IndexOf($query, [StringComparison]::OrdinalIgnoreCase) -ge 0 -or
+                            ($alias -and $alias.IndexOf($query, [StringComparison]::OrdinalIgnoreCase) -ge 0)) {
+                            $binMatches += [System.IO.Path]::GetFileName([string]$exe)
+                        }
                     }
+                    if ($binMatches) { $binaries = $binMatches -join ' | ' }
                 }
-                if ($binMatches) { $binaries = $binMatches -join ' | ' }
-            }
-            $list.Add([PSCustomObject]@{ Name = $appName; Version = $manifest.version; Source = $info.bucket; Binaries = $binaries })
-        } catch { }
+                $list.Add([PSCustomObject]@{ Name = $appName; Version = $manifest.version; Source = $entry.bucket; Binaries = $binaries })
+            } catch { Write-Debug "index search parse failed for $($entry.path): $($_.Exception.Message)" }
+        }
     }
 }