Merge branch 'develop' into fix/scoop-config-scoop-repo-help

Author: B67687

CHANGELOG.md

@@ -7,6 +7,7 @@
 - **install:** Add separator at the end of notes, highlight suggestions ([#6418](https://github.com/ScoopInstaller/Scoop/issues/6418))
 - **download|scoop-download:** Add GitHub issue prompt when the default downloader fails ([#6539](https://github.com/ScoopInstaller/Scoop/issues/6539))
 - **download|scoop-config:** Allow disabling automatic fallback to the default downloader when Aria2c download fails ([#6538](https://github.com/ScoopInstaller/Scoop/issues/6538))
+- **checkver:** Set GitHub mode default jsonpath and regex ([#6653](https://github.com/ScoopInstaller/Scoop/issues/6653))
 
 ### Bug Fixes
 

bin/checkver.ps1

@@ -122,24 +122,22 @@ $Queue | ForEach-Object {
     }
 
     # Not Specified
+    $url = $json.homepage
+    $regex = ''
+    $jsonpath = ''
+    $xpath = ''
+    $replace = ''
+
     if ($json.checkver.url) {
         $url = $json.checkver.url
-    } else {
-        $url = $json.homepage
     }
 
     if ($json.checkver.re) {
         $regex = $json.checkver.re
     } elseif ($json.checkver.regex) {
         $regex = $json.checkver.regex
-    } else {
-        $regex = ''
     }
 
-    $jsonpath = ''
-    $xpath = ''
-    $replace = ''
-
     ## GitHub
     #
     # ```json
@@ -156,7 +154,6 @@ $Queue | ForEach-Object {
     # ```
     if (($json.checkver -eq 'github') -or $json.checkver.github) {
         $githubUrlPattern = '^https://((www\.)?github\.com/[\w.-]+/[\w.-]+/?|api\.github\.com/repos/[\w.-]+/[\w.-]+/.+)$'
-        $regex = if ($regex) { $regex } else { '/releases/tag/(?:v|V)?([\d.]+)' }
 
         $inputGithubUrl = $json.homepage
         $fieldUsed = 'homepage'
@@ -179,6 +176,17 @@ $Queue | ForEach-Object {
             $url = $url -replace '//(www\.)?github\.com/', '//api.github.com/repos/'
             $wc.Headers.Add('Authorization', "token $GitHubToken")
         }
+
+        if ($url -like 'https://api.github.com*') {
+            # Default jsonpath/regex in GitHub API mode
+            $jsonpath = '$.tag_name'
+            if (-not $regex) {
+                $regex = '(?:v|V)?([\d.-]+)'
+            }
+        } elseif (-not $regex) {
+            # Default regex in GitHub HTML mode
+            $regex = '/releases/tag/(?:v|V)?([\d.-]+)'
+        }
     }
 
     # SourceForge