Trying to design simpler inner join

[Dispersia]

Hello, I'm trying to do a similar concept to find_also_related, but for inner joins instead of outer (which can then return a tuple of (element, element) instead of (element, Option). However, I don't understand where the Option part of that query is actually coming from (from select_also). I'm still not great at following traits like this so was just hoping to have some guidance on that, or if this would be a good idea to have through a PR.

Current implementation is just

pub fn find_also_inner_related<R>(self, r: R) -> SelectTwo<E, R>
where
    R: EntityTrait,
    E: Related<R>,
{
    self.join_join(JoinType::InnerJoin, E::to(), E::via())
       .select_also(r)
}

[billy1624]

Hey @Dispersia, welcome!

The code snippet that control returning (element, Option) was

• sea-orm/src/executor/select.rs

  Lines 97 to 110 in a517e9d

  	impl<M, N> SelectorTrait for SelectTwoModel<M, N>
  	where
  	M: FromQueryResult + Sized,
  	N: FromQueryResult + Sized,
  	{
  	type Item = (M, Option<N>);
  	fn from_raw_query_result(res: QueryResult) -> Result<Self::Item, DbErr> {
  	Ok((
  	M::from_query_result(&res, SelectA.as_str())?,
  	N::from_query_result_optional(&res, SelectB.as_str())?,
  	))
  	}
  	}

I think it's good that we can a public API specifically for mandatory relation. A PR would be welcomed!
Feel free to let us know if you need any help :P