Skip to content

Commit 085477e

Browse files
committed
fix: tabs on the detail layout pages should be responsive to external navigation signals
1 parent 49a8d9b commit 085477e

5 files changed

+21
-4
lines changed

src/routes/_auth/(agreements)/agreements.$agreementId._details.summary.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ function Component() {
163163
navigate({
164164
search: (s) => ({ ...s, summary_tab: name }),
165165
resetScroll: false,
166+
replace: true,
166167
});
167168
};
168169

src/routes/_auth/(agreements)/agreements.$agreementId._details.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,11 @@ function Component() {
183183
/>
184184
</Container>
185185
<Container as="div" className="overflow-hidden">
186-
<Tabs defaultValue={currentTab} className="overflow-x-auto">
186+
<Tabs
187+
key={`details_tab_${currentTab}`}
188+
defaultValue={currentTab}
189+
className="overflow-x-auto"
190+
>
187191
<TabsList className="mx-2 sm:mx-4">
188192
<TabsTrigger value="summary" asChild>
189193
<Link

src/routes/_auth/(customers)/customers.$customerId._details.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,11 @@ function Component() {
154154
</Container>
155155
<Separator />
156156
<Container as="div" className="overflow-hidden">
157-
<Tabs defaultValue={currentTab} className="overflow-x-auto">
157+
<Tabs
158+
key={`details_tab_${currentTab}`}
159+
defaultValue={currentTab}
160+
className="overflow-x-auto"
161+
>
158162
<TabsList className="mx-2 sm:mx-4">
159163
<TabsTrigger value="summary" asChild>
160164
<Link

src/routes/_auth/(fleet)/fleet.$vehicleId._details.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,11 @@ function Component() {
152152
/>
153153
</Container>
154154
<Container as="div" className="overflow-hidden">
155-
<Tabs defaultValue={currentTab} className="overflow-x-auto">
155+
<Tabs
156+
key={`details_tab_${currentTab}`}
157+
defaultValue={currentTab}
158+
className="overflow-x-auto"
159+
>
156160
<TabsList className="mx-2 sm:mx-4">
157161
<TabsTrigger value="summary" asChild>
158162
<Link from="/fleet/$vehicleId" to="/fleet/$vehicleId/summary">

src/routes/_auth/(reservations)/reservations.$reservationId._details.tsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,11 @@ function Component() {
158158
/>
159159
</Container>
160160
<Container as="div" className="overflow-hidden">
161-
<Tabs defaultValue={currentTab} className="overflow-x-auto">
161+
<Tabs
162+
key={`details_tab_${currentTab}`}
163+
defaultValue={currentTab}
164+
className="overflow-x-auto"
165+
>
162166
<TabsList className="mx-2 sm:mx-4">
163167
<TabsTrigger value="summary" asChild>
164168
<Link

0 commit comments

Comments
 (0)