Skip to content

Commit 14a14a6

Browse files
[DAGE-88] fixed import
1 parent cc04b74 commit 14a14a6

File tree

9 files changed

+21
-20
lines changed

9 files changed

+21
-20
lines changed

rre-tools/embedding-model-evaluator/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ candidates_path: "resources/mteb_datasets/nfcorpus/test/candidates.jsonl"
1919
# - graded: 0 (not relevant), 1 (maybe ok), 2 (that’s my result)
2020
relevance_scale: "graded"
2121

22-
# (Optional) Path to write mteb resources, if not given it will be written to resources/model_name dir in the root folder
22+
# (Optional) Path to write mteb resources, if not given it will be written to resources dir in the root folder
2323
output_dest: "resources"
2424

2525
# (Optional) Path to write mteb document and query embeddings, if not given it will be written to resources/embeddings dir
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
from pathlib import Path
2+
3+
# Map simple "task key" -> registered MTEB task class name
4+
TASKS_NAME_MAPPING = {
5+
"retrieval": "CustomRetrievalTask",
6+
"reranking": "CustomRerankingTask",
7+
}
8+
9+
CACHE_PATH = Path("resources/cache")
10+
11+
__all__ = [
12+
"TASKS_NAME_MAPPING",
13+
"CACHE_PATH",
14+
]

rre-tools/embedding-model-evaluator/src/embedding_model_evaluator/config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ class Config(BaseModel):
2020
dataset_name: str = Field("custom-dataset", description="Dataset name for MTEB task")
2121
split: str = Field("test", description="Dataset split (train/dev/test)")
2222
output_dest: Optional[Path] = Field(
23-
None, description="Path to save mteb output, by default saved in output dir."
23+
None, description="Path to save mteb output, by default saved in resource dir."
2424
)
2525
embeddings_dest: Optional[Path] = Field(
2626
None,
27-
description="Path to save mteb embeddings, by default saved in <output/embeddings> folder.",
27+
description="Path to save mteb embeddings, by default saved in <resource/embeddings> folder.",
2828
)
2929

3030
@classmethod

rre-tools/embedding-model-evaluator/src/embedding_model_evaluator/main.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import argparse
1414
import logging
15-
from pathlib import Path
1615
from typing import Any
1716

1817
import mteb
@@ -25,12 +24,11 @@
2524
CustomRetrievalTask,
2625
)
2726
from embedding_model_evaluator.writers import EmbeddingWriter
28-
from embedding_model_evaluator.utilities import TASKS_NAME_MAPPING
27+
from embedding_model_evaluator import TASKS_NAME_MAPPING, CACHE_PATH
2928
from commons.logger import configure_logging # type: ignore[import]
3029

3130
log = logging.getLogger(__name__)
3231

33-
CACHE_PATH = Path("resources/cache")
3432
CACHE_PATH.mkdir(parents=True, exist_ok=True)
3533

3634

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +0,0 @@
1-
from embedding_model_evaluator.utilities.helper import TASKS_NAME_MAPPING
2-
3-
__all__ = [
4-
"TASKS_NAME_MAPPING"
5-
]

rre-tools/embedding-model-evaluator/src/embedding_model_evaluator/utilities/helper.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22

33
from jsonlines import jsonlines
44

5-
# Map simple "task key" -> registered MTEB task class name
6-
TASKS_NAME_MAPPING = {
7-
"retrieval": "CustomRetrievalTask",
8-
"reranking": "CustomRerankingTask",
9-
}
10-
115
def read_corpus_reranking(path: Path) -> dict[str, dict[str, str]]:
126
corpus_dict: dict[str, dict[str, str]] = {}
137
with jsonlines.open(path) as rows:

rre-tools/embedding-model-evaluator/src/embedding_model_evaluator/writers/embedding_writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from embedding_model_evaluator.config import Config
1010
from embedding_model_evaluator.custom_tasks.reranking_task import compose_text
1111
from embedding_model_evaluator.utilities.helper import read_corpus_retrieval, read_corpus_reranking, read_queries
12-
from embedding_model_evaluator.utilities import TASKS_NAME_MAPPING
12+
from embedding_model_evaluator import TASKS_NAME_MAPPING
1313

1414
log = logging.getLogger(__name__)
1515

rre-tools/embedding-model-evaluator/tests/unit/test_embedding_writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from embedding_model_evaluator.config import Config
1111
from embedding_model_evaluator.writers.embedding_writer import EmbeddingWriter
12-
from embedding_model_evaluator.utilities.helper import TASKS_NAME_MAPPING
12+
from embedding_model_evaluator import TASKS_NAME_MAPPING
1313

1414

1515
@pytest.fixture

rre-tools/tests/test_cross_plataform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from commons.writers.quepid_writer import QuepidWriter
99
from embedding_model_evaluator.config import Config as MTEBConfig
1010
from embedding_model_evaluator.writers.embedding_writer import EmbeddingWriter
11-
from embedding_model_evaluator.utilities.helper import TASKS_NAME_MAPPING
11+
from embedding_model_evaluator import TASKS_NAME_MAPPING
1212
from dataset_generator.config import Config as DGConfig
1313

1414

0 commit comments

Comments
 (0)