Skip to content

Commit 33ba906

Browse files
[DAGE-73] centralized function setup_logging
1 parent 64a5a5c commit 33ba906

File tree

3 files changed

+10
-17
lines changed
  • rre-tools
    • commons/src/commons
    • dataset-generator/src/dataset_generator
    • embedding-model-evaluator/src/embedding_model_evaluator

3 files changed

+10
-17
lines changed

rre-tools/commons/src/commons/logger.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ def configure_logging(level: Union[str, int] = logging.INFO) -> None:
2424
datefmt='%H:%M:%S'
2525
)
2626

27+
def setup_logging(verbose: bool = False) -> None:
28+
if verbose:
29+
configure_logging(logging.DEBUG)
30+
else:
31+
configure_logging(logging.INFO)
32+
return
33+
2734
# EXAMPLE:
2835
if __name__ == "__main__":
2936
# 1. Configure logging

rre-tools/dataset-generator/src/dataset_generator/main.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88

99
from typing import List
1010
from langchain_core.language_models import BaseChatModel
11-
from logging import Logger, getLogger, DEBUG, INFO
11+
from logging import Logger, getLogger
1212

1313
# project imports
1414
from dataset_generator.config import Config
1515
from dataset_generator.utils import parse_args
16-
from commons.logger import configure_logging
16+
from commons.logger import setup_logging
1717
from dataset_generator.llm import LLMConfig, LLMService, LLMServiceFactory
1818
from commons.model import Document, Query, LLMQueryResponse, LLMScoreResponse, WriterConfig
1919
from commons.writers import WriterFactory, AbstractWriter
@@ -23,13 +23,6 @@
2323
log: Logger = getLogger(__name__)
2424

2525

26-
def setup_logging(verbose: bool = False) -> None:
27-
if verbose:
28-
configure_logging(DEBUG)
29-
else:
30-
configure_logging(INFO)
31-
return
32-
3326

3427
def add_user_queries(config: Config, data_store: DataStore) -> None:
3528
"""Loads queries from file (if exists) and adds them as Query objects."""

rre-tools/embedding-model-evaluator/src/embedding_model_evaluator/main.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
)
2626
from embedding_model_evaluator.writers import EmbeddingWriter
2727
from embedding_model_evaluator import TASKS_NAME_MAPPING, CACHE_PATH
28-
from commons.logger import configure_logging # type: ignore[import]
28+
from commons.logger import setup_logging # type: ignore[import]
2929

3030
log = logging.getLogger(__name__)
3131

@@ -46,13 +46,6 @@ def _parse_args() -> argparse.Namespace:
4646

4747
return parser.parse_args()
4848

49-
def setup_logging(verbose: bool = False) -> None:
50-
if verbose:
51-
configure_logging(logging.DEBUG)
52-
else:
53-
configure_logging(logging.INFO)
54-
return
55-
5649

5750
def _build_task(task_key: str, dataset_name: str, split: str) -> Any:
5851
"""

0 commit comments

Comments
 (0)