Skip to content

Commit 89347f4

Browse files
[DAGE-66] changed a bit the tests to avoid boilerplate code
1 parent 45c3fad commit 89347f4

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

rre-tools/tests/approximate_search_evaluator/test_config_approximate_search_evaluator.py

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -51,26 +51,13 @@ def test_missing_optional_solr_field_values__expects__all_defaults_read(resource
5151
assert config.embeddings_folder is None
5252

5353

54-
def test_missing_query_template__expects__raises_validation_error(resource_folder):
55-
file_name = "missing_query_template.yaml"
56-
with pytest.raises(ValidationError):
57-
_ = Config.load(resource_folder / file_name)
58-
59-
60-
def test_missing_search_engine_type__expects__raises_validation_error(resource_folder):
61-
file_name = "missing_search_engine_type.yaml"
62-
with pytest.raises(ValidationError):
63-
_ = Config.load(resource_folder / file_name)
64-
65-
66-
def test_missing_collection_name__expects__raises_validation_error(resource_folder):
67-
file_name = "missing_collection_name.yaml"
68-
with pytest.raises(ValidationError):
69-
_ = Config.load(resource_folder / file_name)
70-
71-
72-
def test_missing_search_engine_url__expects__raises_validation_error(resource_folder):
73-
file_name = "missing_search_engine_url.yaml"
54+
@pytest.mark.parametrize("file_name", [
55+
"missing_query_template.yaml",
56+
"missing_search_engine_type.yaml",
57+
"missing_collection_name.yaml",
58+
"missing_search_engine_url.yaml"
59+
])
60+
def test_missing_non_optional_field__expects__raises_validation_error(resource_folder, file_name):
7461
with pytest.raises(ValidationError):
7562
_ = Config.load(resource_folder / file_name)
7663

0 commit comments

Comments
 (0)