feat: Add message command to send direct messages #632

hemati · 2025-09-28T09:07:27Z

ℹ️ Description

Provide a concise summary of the changes introduced in this pull request.

Link to the related issue(s): Issue #
Describe the motivation and context for this change.

📋 Changes Summary

Bullet-point key changes introduced.
Mention any dependencies, configuration changes, or additional requirements introduced.

⚙️ Type of Change

Select the type(s) of change(s) included in this pull request:

🐞 Bug fix (non-breaking change which fixes an issue)
✨ New feature (adds new functionality without breaking existing usage)
💥 Breaking change (changes that might break existing user setups, scripts, or configurations)

✅ Checklist

Before requesting a review, confirm the following:

I have reviewed my changes to ensure they meet the project's standards.
I have tested my changes and ensured that all tests pass (pdm run test).
I have formatted the code (pdm run format).
I have verified that linting passes (pdm run lint).
I have updated documentation where necessary.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…stings

…ut to ainput for async compatibility

…ssages

codecov · 2025-09-28T14:16:15Z

Codecov Report

❌ Patch coverage is 22.91667% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.14%. Comparing base (a8a3f83) to head (bfbd95d).

Files with missing lines	Patch %	Lines
src/kleinanzeigen_bot/message.py	22.91%	37 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #632      +/-   ##
==========================================
- Coverage   79.56%   78.14%   -1.43%     
==========================================
  Files          20       21       +1     
  Lines        1860     1908      +48     
  Branches      370      372       +2     
==========================================
+ Hits         1480     1491      +11     
- Misses        243      280      +37     
  Partials      137      137

Flag	Coverage Δ
integration-tests	`78.14% <22.91%> (-1.43%)`	⬇️
smoke-tests	`78.14% <22.91%> (-1.43%)`	⬇️
unit-tests	`78.14% <22.91%> (-1.43%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…handling and conversation fetching

feat: Enhance Messenger and WebScrapingMixin to support user profile …

…gument parsing and validation

1cu

Required before merge:

Fix linting errors
Remove German comments and variables
Remove commented-out code
Add tests
Add proper docstrings

Strongly recommended

Improve error handling and messages
Fix type annotations
Extract command setup logic

1cu · 2025-10-11T15:33:00Z

src/kleinanzeigen_bot/__init__.py

                    await self.create_browser_session()
                    await self.login()
                    await self.download_ads()
+                case "message":


This adds quite a lot of new statements and the linter is failing cause of too many statements. Do avoid a larger refactor of the commands you could use a new method to handle the commands in this case. I'm unsure - what do you think @Heavenfighter ?

I'm also unsure about the command structure.

1cu · 2025-10-11T15:33:50Z

src/kleinanzeigen_bot/message.py

+LOG:Final[loggers.Logger] = loggers.get_logger(__name__)
+
+
+class Messenger(WebScrapingMixin):


Pretty low test coverage for this one. Please add tests for send_message_to_listing(), fetch_conversation() and fetch_conversation()

1cu · 2025-10-11T15:34:18Z

src/kleinanzeigen_bot/message.py

+    # public API
+    # ---------------------------
+    async def send_message_to_listing(self, listing_url:str, message_text:str) -> bool:
+        # LOG.info(i18n.gettext("Opening ad page: %s"), listing_url)


If it's not used - remove it

1cu · 2025-10-11T15:34:31Z

src/kleinanzeigen_bot/message.py

+        # LOG.info(i18n.gettext("Opening ad page: %s"), listing_url)
+        await self.web_open(listing_url, timeout = 15_000)
+
+        # Kleiner Scroll, damit „Kontakt“-Button gerendert ist


English please

1cu · 2025-10-11T15:34:45Z

src/kleinanzeigen_bot/message.py

+            send_btn_candidates, desc = "send message button", timeout = 6
+        )
+
+        # 4) kurze Heuristik/Abschluss


English please

1cu · 2025-10-11T15:46:20Z

src/kleinanzeigen_bot/__init__.py

+                case "message":
+                    self.configure_file_logging()
+                    self.load_config()
+                    # Optional, wie bei anderen Commands:


English please.

1cu · 2025-10-11T15:46:57Z

src/kleinanzeigen_bot/__init__.py

+                        LOG.info("DONE: Message could not be confirmed.")
+                        LOG.info("############################################")
+
+                case "fetch-conversations":


All commands have a similar setup - could be extracted to common setup logic.

1cu · 2025-10-11T15:48:07Z

src/kleinanzeigen_bot/message.py

+            (By.TAG_NAME, "textarea"),
+        ]
+        textarea = await self._try_find(
+            textarea_candidates, desc = "message textarea", timeout = 8


Several magic numbers that should be constants and explained.

1cu · 2025-10-11T15:48:18Z

src/kleinanzeigen_bot/message.py

+            ),
+        ]
+        await self._try_click(
+            open_btn_candidates, desc = "message open button", timeout = 6


Several magic numbers that should be constants and explained.

1cu · 2025-10-11T15:49:49Z

src/kleinanzeigen_bot/__init__.py

 import urllib.parse as urllib_parse
 from gettext import gettext as _
-from typing import Any, Final
+from typing import Any, Dict, Final


We use dict

1cu · 2025-10-11T15:52:56Z

This PR lacks any summary or explanation in the summary...

Heavenfighter · 2025-10-21T11:21:26Z

I'm unsure about the purpose of the extension. The bot is mainly supposed to post/update ads.
Where do you get the ID if you want to write a message about an ad? You can only get it manually, right?
What is the point of the downloaded messages? They are only output as JSON.
I see more of a risk here that this feature could be used as a spam generator.

hemati added 3 commits September 28, 2025 10:39

feat: Implement message sending functionality to Kleinanzeigen listings

12d929f

feat: Add message command to send direct messages to Kleinanzeigen li…

15ab961

…stings

fix: Update message_url and message_text type annotations; change inp…

2b400ed

…ut to ainput for async compatibility

github-actions bot added the enhancement New feature or request label Sep 28, 2025

feat: Add German translations for message command usage and status me…

bfbd95d

…ssages

hemati and others added 4 commits September 28, 2025 17:44

feat: Enhance Messenger and WebScrapingMixin to support user profile …

5835fe0

…handling and conversation fetching

Merge pull request #1 from hemati/conversations

8dc03f8

feat: Enhance Messenger and WebScrapingMixin to support user profile …

feat: Add fetch-conversations and fetch-conversation commands with ar…

dce1089

…gument parsing and validation

Merge branch 'main' of https://github.com/hemati/kleinanzeigen-bot

79d15e4

1cu requested changes Oct 11, 2025

View reviewed changes

		LOG:Final[loggers.Logger] = loggers.get_logger(__name__)


		class Messenger(WebScrapingMixin):

feat: Add message command to send direct messages #632

Are you sure you want to change the base?

feat: Add message command to send direct messages #632

Uh oh!

Conversation

hemati commented Sep 28, 2025

ℹ️ Description

📋 Changes Summary

⚙️ Type of Change

✅ Checklist

Uh oh!

codecov bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

1cu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1cu commented Oct 11, 2025

Uh oh!

Heavenfighter commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 28, 2025 •

edited

Loading