Make Played Music and Sound Effects Configurable Through Config Files...

[datahead8888]

Much as @brianvanderburg2 made animations configurable through .imgset files, we might consider making music and sound effects configurable through config files. This will allow existing music/sound to be changed without making code changes. It also opens the door for usage with programs like https://github.com/Secretchronicles/Settingseditor to edit the music.

We might consider allowing the user to configure the songs / sound effects played within the TSC user interface eventually. This could be integrated with packaging. If there is an interest in this, we could open a second ticket, as this is a different task.

[Quintus]

This will allow existing music/sound to be changed without making code changes.

Errm, what? The music/sound stuff never required code changes.

Apart from that, I repeat what I said to Brian earlier. TSC is not a game engine. We have an identity to maintain.

Vale,
Quintus

[datahead8888]

Errm, what? The music/sound stuff never required code changes.

Changing a file name referenced by the code does, but, no, swapping a file does not.

As for personal adjustment of music, this is really not any different than the other packaging features. In most cases, people would just do it on their personal computers.

Apart from that, I repeat what I said to Brian earlier. TSC is not a game engine.

It's a valid point for discussion. I'm not really fond of large numbers of config files myself generally. I like messing with code, not config files, when I can.

[brianvanderburg2]

One feature it could support with such things may be some dynamic sound effects. For example, something like PlaySound("thunder") may reference a configuration which uses thunder sounds and picks one randomly perhaps with a certain probability, much like the image set animation branching feature. But outside of such corner cases, I don't really see the need for it.

As a personal preference for all of the code, music, sounds, even images, I would love to get rid of file extensions within the code and just reference a path and name. Instead of LoadImage("path/to/image.png"), I think LoadImage("path/to/image") is cleaner, allows future changes behind the scenes without messy/odd code, etc.

[datahead8888]

Apart from that, I repeat what I said to Brian earlier. TSC is not a game engine. We have an identity to maintain.

Does the packaging system currently allow the song file played for each track to be configured through a package? If it does not do this but does allow configuring of the images, I think this should be added for consistency. This, however, would be a different task, since this task was about using config files to set up default music files rather than just C++ code.

[Quintus]

I think the current situation is good enough. Don't create a problem where there is none. I suggest not implementing this. We've so much to still do anyway...