Skip to content

Commit c8b1e0e

Browse files
committed
Fix serialization implementation
1 parent 3e92e9d commit c8b1e0e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/Monolog/Logger.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,7 @@ public function __unserialize(array $data): void
741741
{
742742
foreach (['name', 'handlers', 'processors', 'microsecondTimestamps', 'timezone', 'exceptionHandler', 'logDepth', 'detectCycles'] as $property) {
743743
if (isset($data[$property])) {
744-
$this->$property = $data;
744+
$this->$property = $data[$property];
745745
}
746746
}
747747

tests/Monolog/LoggerTest.php

+5-1
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,11 @@ public function testCustomHandleException()
700700
public function testSerializable()
701701
{
702702
$logger = new Logger(__METHOD__);
703-
self::assertInstanceOf(Logger::class, unserialize(serialize($logger)));
703+
$copy = unserialize(serialize($logger));
704+
self::assertInstanceOf(Logger::class, $copy);
705+
self::assertSame($logger->getName(), $copy->getName());
706+
self::assertSame($logger->getTimezone()->getName(), $copy->getTimezone()->getName());
707+
self::assertSame($logger->getHandlers(), $copy->getHandlers());
704708
}
705709

706710
public function testReset()

0 commit comments

Comments
 (0)