Skip to content

Commit bcafdfa

Browse files
Fixed code registry but need to remove duplicated json encoding code from hf runtime
1 parent bb0db42 commit bcafdfa

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

mlserver/codecs/json.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from .string import decode_str
1313
from .lists import as_list
1414
from .utils import InputOrOutput, SingleInputRequestCodec
15-
from .base import InputCodec, register_input_codec, register_request_codec
15+
from .base import InputCodec
1616
from ..types import RequestInput, ResponseOutput, Parameters
1717

1818

@@ -95,7 +95,6 @@ def _is_nested_primitives(obj):
9595
return False
9696

9797

98-
@register_input_codec
9998
class JSONCodec(InputCodec):
10099
"""
101100
Encodes a list of Python objects as a BYTES input (output).
@@ -160,7 +159,6 @@ def encode_input(
160159
)
161160

162161

163-
@register_request_codec
164162
class JSONRequestCodec(SingleInputRequestCodec):
165163
"""
166164
Decodes the first input (output) of request (response) as a NumPy array.

runtimes/mlflow/mlserver_mlflow/runtime.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from mlserver.errors import InferenceError
2323
from mlserver.settings import ModelParameters
2424
from mlserver.logging import logger
25+
from mlserver.codecs import JSONCodec
2526

2627
from .codecs import TensorDictCodec
2728
from .metadata import (
@@ -195,7 +196,7 @@ def _sync_metadata(self) -> None:
195196
)
196197

197198
async def predict(self, payload: InferenceRequest) -> InferenceResponse:
198-
decoded_payload = self.decode_request(payload)
199+
decoded_payload = self.decode_request(payload, default_codec=JSONCodec)
199200
params = None
200201
if payload.parameters and payload.parameters.model_extra:
201202
params = payload.parameters.model_extra

0 commit comments

Comments
 (0)