Improve the extendibility of WebDriverCommandProcessor

[lukeis]

Originally reported on Google Code with ID 6479

Description
===========
The attached patch improves the extendibility of WebDriverCommandProcessor.

- for getting raw result value, change access modifier of execute() into "public".
- for using in user-defined command or for injecting user-defined processing,
  add setter/getter of internal objects used in pre-defined command.

Reason
======
I am creating selenese interpreter. ( https://github.com/vmi/selenese-runner-java )
I want to get a raw result value of execute() method because it's type cannot be determined
statically.
And I want to access internal objects used in pre-defined command (for example, like
ElementFinder),
in order to register my command or to inject my processing into pre-defined command.

Benefits
========
WebDriverCommandProcessor becomes more general-purpose parts.

Drawbacks
=========
I think there is no drawback.

Reported by vmi@nifty.com on 2013-10-25 14:14:58

---

- _Attachment: [WDCP.diff](https://storage.googleapis.com/google-code-attachments/selenium/issue-6479/comment-0/WDCP.diff)_

[lukeis]

Reported by barancev on 2013-10-25 18:15:11

• Labels added: Lang-Java

[lukeis]

There is public method doCommand in WebDriverCommandProcessor. Is not this method enough
for your purpose?

Reported by barancev on 2013-10-30 11:40:45

• Status changed: NeedsClarification

[lukeis]

Since "doCommand" returns a return value by "toString", "doCommand" destroys the return
value which is "String[]".

Reported by vmi@nifty.com on 2013-10-31 22:44:15

[lukeis]

Since my program reads commands from a file, the type of a return value cannot be determined
statically. 

Reported by vmi@nifty.com on 2013-10-31 22:51:14

[lukeis]

What kind of problem is there in my patch? 

Reported by vmi@nifty.com on 2013-11-27 23:16:47

[lukeis]

Adding your own commands can be done by calling WebDriverCommandProcessor.addMethod().
This does no checking that the method already exists and just overwrites existing ones.


That means that you can new up your own ElementFinder and override the "addStrategy"
method to keep it in sync with the one referred to by the other commands. JavascriptLibrary
is the same.

Have you got a concrete example of where the existing mechanisms aren't sufficient?

The reason we're not keen to put much effort into this is that in Selenium 3, the original
Core implementations are being removed: http://seleniumhq.wordpress.com/2013/08/28/the-road-to-selenium-3/

Reported by simon.m.stewart on 2014-01-28 16:58:52

[lukeis]

Reported by luke.semerau on 2015-09-17 17:45:56

• Labels added: Restrict-AddIssueComment-Commit