Possible race in ExpectedConditions.visibilityOfAllElementsLocatedBy()

[lukeis]

Originally reported on Google Code with ID 7134

What steps will reproduce the problem?

1. Use wait.until(ExpectedConditions.not(ExpectedConditions.visibilityOfAllElementsLocatedBy(By.className('my-class'))))
to wait for an element to disappear.
2. This sometimes throws an exception while calling element.isDisplayed(). I was able
to reproduce it only when using RemoteWebDriver on a (slow) virtual machine running
Windows 7.

It seems there is a race condition in visibilityOfAllElementsLocatedBy() between retrieving
the element and calling isDisplayed() on it. When the element disappears after the
findElements() call but before the isDisplayed call a StaleElementReferenceException
is thrown. Other calls to isDisplayed(), e.g. in invisibilityOfElementLocated(), catch
NoSuchElementException and StaleElementReferenceException. I think these should also
be caught in visibilityOfAllElementsLocatedBy().

Selenium version: 2.39.0
OS: Windows 7
Browser: Chrome/Firefox

Reported by leroy.vanengelen on 2014-03-27 11:53:59

[lukeis]

Reported by barancev on 2014-04-08 13:43:51

• Status changed: Accepted
• Labels added: Lang-Java

[lukeis]

Please look at the comments on the following pull request originally raised for the
said issue.

https://github.com/SeleniumHQ/selenium/pull/234

A particular exception or a list of exceptions can be ignored by using ignoring method
on the FluentWait class object.

I feel we should handle the StaleElementReferenceException for all the utils where
user is providing a By class object. Since its selenium responsibility to find a valid
element and return it based on a particular condition.
As part of this we should also remove any StaleElementReferenceException handling done
for the utils where a user is providing a WebElement or a List of WebElement class
objects and leave it to the user whether to ignore StaleElementReferenceException or
not. 

Reported by mr.varun.menon on 2014-07-08 07:40:30

[lukeis]

Reported by luke.semerau on 2015-09-17 17:46:34

• Labels added: Restrict-AddIssueComment-Commit