Merge branch 'v3' into multi-select

Author: david califf

Diff for: .github/PULL_REQUEST_TEMPLATE.md

@@ -1 +1,8 @@
+<!--
+Selenium IDE is moving to an electron app!!!.
+For the time being the team will support both the extension and the app, until the app reaches complete feature parity with the extension.
+
+If you want to submit a PR to the electron app, please submit to master.
+To submit a PR to the extension submit to the branch v3
+-->
 - [ ] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)

Diff for: babel.config.js

@@ -0,0 +1,13 @@
+const fs = require('fs')
+const path = require('path')
+
+module.exports = {
+  babelrcRoots: fs
+    .readdirSync('packages')
+    .map(dirname => path.join(process.cwd(), 'packages', dirname))
+    .filter(dirpath => {
+      const stats = fs.statSync(dirpath)
+
+      return stats.isDirectory()
+    }),
+}

Diff for: docs/introduction/faq.md

@@ -62,3 +62,14 @@ __NOTE: If you already have the plugin installed (e.g., on the laptop you're try
 * [Download instructions for the required ".crx" installer](https://stackoverflow.com/questions/25480912/how-to-download-a-chrome-extension-without-installing-it)
 
 __NOTE: you can't obtain the ".crx" file directly from the Chrome store. Instead, you need to install it once locally, and then go to the installation directory on your machine to retrieve it.__
+
+### Why does no save dialog appear once a plugin is attached?
+Due to a current [Chrome bug](https://bugs.chromium.org/p/chromium/issues/detail?id=922373), if you don't reply to the emitted message from Selenium IDE, further processing won't happen. In order to workaround the issue, make sure to listen for the action `emit` with the entity `project` and reply with `undefined`:
+
+```javascript
+chrome.runtime.onMessageExternal.addListener((message, sender, sendResponse) => {
+  if (message.action === "emit" && message.entity === "project") {
+    sendResponse(undefined);
+  }
+});
+```

Diff for: lerna.json

@@ -3,6 +3,6 @@
   "packages": [
     "packages/*"
   ],
-  "version": "3.5.9",
+  "version": "3.5.11",
   "npmClient": "yarn"
 }

Diff for: package.json

@@ -30,27 +30,29 @@
     "moduleNameMapper": {
       "^.+\\.(css|scss)$": "identity-obj-proxy"
     },
-    "setupTestFrameworkScriptFile": "./packages/selenium-ide/scripts/jest/test.config.js",
+    "setupFilesAfterEnv": [
+      "./packages/selenium-ide/scripts/jest/test.config.js"
+    ],
     "testMatch": [
       "**/packages/**/__test?(s)__/**/*.js?(x)"
     ]
   },
   "devDependencies": {
+    "@babel/core": "^7.3.4",
     "babel-eslint": "^10.0.1",
-    "babel-jest": "^23.6.0",
+    "babel-jest": "^24.3.1",
     "eslint": "^5.8.0",
     "eslint-config-prettier": "^3.1.0",
     "eslint-plugin-jest": "^21.27.1",
     "eslint-plugin-prettier": "^3.0.0",
     "eslint-plugin-react": "^7.11.1",
     "identity-obj-proxy": "^3.0.0",
-    "jest": "^23.6.0",
+    "jest": "^24.3.1",
     "lerna": "^3.4.3",
     "prettier": "^1.14.3",
     "stylelint": "^9.7.1",
     "stylelint-config-prettier": "^4.0.0",
     "stylelint-config-standard": "^18.2.0",
-    "stylelint-prettier": "^1.0.3",
-    "web-ext": "^2.4.0"
+    "stylelint-prettier": "^1.0.3"
   }
 }

Diff for: packages/browser-webdriver/.babelrc

@@ -1,3 +1,12 @@
 {
-  presets: [ "node8" ]
+  "presets": [
+    [
+      "@babel/preset-env",
+      {
+        "targets": {
+          "node": "8"
+        }
+      }
+    ]
+  ]
 }

Diff for: packages/browser-webdriver/package.json

@@ -1,6 +1,6 @@
 {
   "name": "browser-webdriver",
-  "version": "3.5.9",
+  "version": "3.5.10",
   "main": "build/webdriver.js",
   "repository": "https://github.com/SeleniumHQ/selenium-ide",
   "license": "Apache-2.0",
@@ -13,8 +13,8 @@
     "build/webdriver.js"
   ],
   "devDependencies": {
-    "babel-cli": "^6.26.0",
-    "babel-preset-node8": "^1.2.0",
+    "@babel/cli": "^7.2.3",
+    "@babel/preset-env": "^7.3.4",
     "browserify": "^16.2.2",
     "selenium-webdriver": "3.6.0",
     "watchify": "^3.11.0"