Skip to content

[🚀 Feature]: [dotnet] [bidi] Reevaluate nullable parameters in DTO constructors #15561

Open
@nvborisenko

Description

@nvborisenko

Description

Example:

browsingContext.Info = {
  children: browsingContext.InfoList / null,
  clientWindow: browser.ClientWindow,
  ? parent: browsingContext.BrowsingContext / null,
}

In .net it should be:

public record BrowsingContextInfo(IReadOnlyList<BrowsingContextInfo>? Children, Browser.ClientWindow ClientWindow)
{
    [JsonInclude]
    public BrowsingContext? Parent { get; internal set; }
}

So, children prop is in ctor (as for now), BUT it should be nullable because of browsingContext.InfoList / null. This is only about it: review all / null entries in spec and make appropriate type as nullable.

Have you considered any alternatives or workarounds?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    B-devtoolsIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET BindingsI-enhancementSomething could be better

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions