From 58d988f86ac7fe5171e880adc1607f8053ed7201 Mon Sep 17 00:00:00 2001
From: Michael Render
Date: Sat, 8 Mar 2025 00:18:32 -0500
Subject: [PATCH] [dotnet] Address nullable warnings
---
dotnet/src/webdriver/DevTools/v131/V131Network.cs | 8 ++++----
dotnet/src/webdriver/DevTools/v132/V132Network.cs | 8 ++++----
dotnet/src/webdriver/DevTools/v133/V133Network.cs | 8 ++++----
dotnet/src/webdriver/DevTools/v85/V85Network.cs | 8 ++++----
dotnet/src/webdriver/WebDriver.cs | 2 +-
5 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/dotnet/src/webdriver/DevTools/v131/V131Network.cs b/dotnet/src/webdriver/DevTools/v131/V131Network.cs
index 74d4d58a46a53..cd5b6113eb876 100644
--- a/dotnet/src/webdriver/DevTools/v131/V131Network.cs
+++ b/dotnet/src/webdriver/DevTools/v131/V131Network.cs
@@ -191,7 +191,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
var commandSettings = new FulfillRequestCommandSettings()
{
- RequestId = requestData.RequestId,
+ RequestId = requestData.RequestId!,
ResponseCode = responseData.StatusCode,
};
@@ -232,7 +232,7 @@ public override async Task ContinueRequestWithoutModification(HttpRequestData re
throw new ArgumentNullException(nameof(requestData));
}
- await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId! }).ConfigureAwait(false);
}
///
@@ -289,7 +289,7 @@ public override async Task AddResponseBody(HttpResponseData responseData)
// If the response is a redirect, retrieving the body will throw an error in CDP.
if (responseData.StatusCode < 300 || responseData.StatusCode > 399)
{
- var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
if (bodyResponse != null)
{
if (bodyResponse.Base64Encoded)
@@ -317,7 +317,7 @@ public override async Task ContinueResponseWithoutModification(HttpResponseData
throw new ArgumentNullException(nameof(responseData));
}
- await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
}
private void OnFetchAuthRequired(object? sender, Fetch.AuthRequiredEventArgs e)
diff --git a/dotnet/src/webdriver/DevTools/v132/V132Network.cs b/dotnet/src/webdriver/DevTools/v132/V132Network.cs
index ea7472b7afded..f8d9608b8a3a5 100644
--- a/dotnet/src/webdriver/DevTools/v132/V132Network.cs
+++ b/dotnet/src/webdriver/DevTools/v132/V132Network.cs
@@ -191,7 +191,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
var commandSettings = new FulfillRequestCommandSettings()
{
- RequestId = requestData.RequestId,
+ RequestId = requestData.RequestId!,
ResponseCode = responseData.StatusCode,
};
@@ -232,7 +232,7 @@ public override async Task ContinueRequestWithoutModification(HttpRequestData re
throw new ArgumentNullException(nameof(requestData));
}
- await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId! }).ConfigureAwait(false);
}
///
@@ -289,7 +289,7 @@ public override async Task AddResponseBody(HttpResponseData responseData)
// If the response is a redirect, retrieving the body will throw an error in CDP.
if (responseData.StatusCode < 300 || responseData.StatusCode > 399)
{
- var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
if (bodyResponse != null)
{
if (bodyResponse.Base64Encoded)
@@ -317,7 +317,7 @@ public override async Task ContinueResponseWithoutModification(HttpResponseData
throw new ArgumentNullException(nameof(responseData));
}
- await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
}
private void OnFetchAuthRequired(object? sender, Fetch.AuthRequiredEventArgs e)
diff --git a/dotnet/src/webdriver/DevTools/v133/V133Network.cs b/dotnet/src/webdriver/DevTools/v133/V133Network.cs
index e9634fb7eda2c..b5cbd81e5addd 100644
--- a/dotnet/src/webdriver/DevTools/v133/V133Network.cs
+++ b/dotnet/src/webdriver/DevTools/v133/V133Network.cs
@@ -191,7 +191,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
var commandSettings = new FulfillRequestCommandSettings()
{
- RequestId = requestData.RequestId,
+ RequestId = requestData.RequestId!,
ResponseCode = responseData.StatusCode,
};
@@ -232,7 +232,7 @@ public override async Task ContinueRequestWithoutModification(HttpRequestData re
throw new ArgumentNullException(nameof(requestData));
}
- await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId! }).ConfigureAwait(false);
}
///
@@ -289,7 +289,7 @@ public override async Task AddResponseBody(HttpResponseData responseData)
// If the response is a redirect, retrieving the body will throw an error in CDP.
if (responseData.StatusCode < 300 || responseData.StatusCode > 399)
{
- var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
if (bodyResponse != null)
{
if (bodyResponse.Base64Encoded)
@@ -317,7 +317,7 @@ public override async Task ContinueResponseWithoutModification(HttpResponseData
throw new ArgumentNullException(nameof(responseData));
}
- await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueResponse(new ContinueResponseCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
}
private void OnFetchAuthRequired(object? sender, Fetch.AuthRequiredEventArgs e)
diff --git a/dotnet/src/webdriver/DevTools/v85/V85Network.cs b/dotnet/src/webdriver/DevTools/v85/V85Network.cs
index 8c70104abbe47..6aa72377abaac 100644
--- a/dotnet/src/webdriver/DevTools/v85/V85Network.cs
+++ b/dotnet/src/webdriver/DevTools/v85/V85Network.cs
@@ -191,7 +191,7 @@ public override async Task ContinueRequestWithResponse(HttpRequestData requestDa
var commandSettings = new FulfillRequestCommandSettings()
{
- RequestId = requestData.RequestId,
+ RequestId = requestData.RequestId!,
ResponseCode = responseData.StatusCode,
};
@@ -232,7 +232,7 @@ public override async Task ContinueRequestWithoutModification(HttpRequestData re
throw new ArgumentNullException(nameof(requestData));
}
- await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = requestData.RequestId! }).ConfigureAwait(false);
}
///
@@ -289,7 +289,7 @@ public override async Task AddResponseBody(HttpResponseData responseData)
// If the response is a redirect, retrieving the body will throw an error in CDP.
if (responseData.StatusCode < 300 || responseData.StatusCode > 399)
{
- var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ var bodyResponse = await fetch.GetResponseBody(new Fetch.GetResponseBodyCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
if (bodyResponse.Base64Encoded)
{
responseData.Content = new HttpResponseContent(Convert.FromBase64String(bodyResponse.Body));
@@ -314,7 +314,7 @@ public override async Task ContinueResponseWithoutModification(HttpResponseData
throw new ArgumentNullException(nameof(responseData));
}
- await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = responseData.RequestId }).ConfigureAwait(false);
+ await fetch.ContinueRequest(new ContinueRequestCommandSettings() { RequestId = responseData.RequestId! }).ConfigureAwait(false);
}
private void OnFetchAuthRequired(object? sender, Fetch.AuthRequiredEventArgs e)
diff --git a/dotnet/src/webdriver/WebDriver.cs b/dotnet/src/webdriver/WebDriver.cs
index c9bfdd4c93f04..d62f08ce278af 100644
--- a/dotnet/src/webdriver/WebDriver.cs
+++ b/dotnet/src/webdriver/WebDriver.cs
@@ -40,7 +40,7 @@ public class WebDriver : IWebDriver, ISearchContext, IJavaScriptExecutor, IFinds
///
protected static readonly TimeSpan DefaultCommandTimeout = TimeSpan.FromSeconds(60);
private IFileDetector fileDetector = new DefaultFileDetector();
- private NetworkManager network;
+ private NetworkManager? network;
private WebElementFactory elementFactory;
private readonly List registeredCommands = new List();