From 06465dc8e02a2e3537b07681d567a066abd416a3 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Fri, 4 Apr 2025 17:03:19 -0400 Subject: [PATCH 1/3] trying to fix flaky test --- .../selenium/webdriver/common/driver_element_finding_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/driver_element_finding_tests.py b/py/test/selenium/webdriver/common/driver_element_finding_tests.py index 205edb92e1f88..d7a0e06f5167b 100644 --- a/py/test/selenium/webdriver/common/driver_element_finding_tests.py +++ b/py/test/selenium/webdriver/common/driver_element_finding_tests.py @@ -354,7 +354,7 @@ def test_should_be_able_to_identify_elements_by_class(driver, pages): def test_should_be_able_to_find_an_element_by_xpath_with_multiple_attributes(driver, pages): pages.load("formPage.html") - element = driver.find_element(By.XPATH, "//form[@name='optional']/input[@type='submit' and @value='Click!']") + element = driver.find_element(By.XPATH, "/input[@type='email' and @id='email']") assert element.tag_name.lower() == "input" assert element.get_attribute("value") == "Click!" From e621c2c549cf10a79e8009db7a837ab25cc5c6f1 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Fri, 4 Apr 2025 17:19:16 -0400 Subject: [PATCH 2/3] passed locally --- .../selenium/webdriver/common/driver_element_finding_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/test/selenium/webdriver/common/driver_element_finding_tests.py b/py/test/selenium/webdriver/common/driver_element_finding_tests.py index d7a0e06f5167b..d8209e14aea29 100644 --- a/py/test/selenium/webdriver/common/driver_element_finding_tests.py +++ b/py/test/selenium/webdriver/common/driver_element_finding_tests.py @@ -354,7 +354,7 @@ def test_should_be_able_to_identify_elements_by_class(driver, pages): def test_should_be_able_to_find_an_element_by_xpath_with_multiple_attributes(driver, pages): pages.load("formPage.html") - element = driver.find_element(By.XPATH, "/input[@type='email' and @id='email']") + element = driver.find_element(By.XPATH, "//input[@type='submit' and @value='Click!']") assert element.tag_name.lower() == "input" assert element.get_attribute("value") == "Click!" From 63deaf4c22b0bf93d8230a2482e0013c0f39b82b Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Fri, 4 Apr 2025 17:35:21 -0400 Subject: [PATCH 3/3] added xfail for consistently failing firefox test --- py/test/selenium/webdriver/common/webdriverwait_tests.py | 1 + 1 file changed, 1 insertion(+) diff --git a/py/test/selenium/webdriver/common/webdriverwait_tests.py b/py/test/selenium/webdriver/common/webdriverwait_tests.py index f332933e4241c..206e0fb64d916 100644 --- a/py/test/selenium/webdriver/common/webdriverwait_tests.py +++ b/py/test/selenium/webdriver/common/webdriverwait_tests.py @@ -101,6 +101,7 @@ def test_should_fail_to_find_visible_elements_when_explicit_waiting(driver, page WebDriverWait(driver, 0.7).until(EC.visibility_of_any_elements_located((By.CLASS_NAME, "redbox"))) +@pytest.mark.xfail_firefox def test_should_wait_until_all_visible_elements_are_found_when_searching_for_many(driver, pages): pages.load("hidden_partially.html") add_visible = driver.find_element(By.ID, "addVisible")