Hi. We had a bad tool token saved to our github secrets last week. (totally our fault). But it exposed something unexpected:
When we were modifying an existing CHG, we got a silent failure in the github workflow log. However, when creating a new CHG with the "servicenow-devops-change" action, we were getting a 403 response.
It looks to me like... maybe the code linked above just skips over 403 errors? There's no output for errors other than 400|401|405|500 and CONNREFUSED. And the github action returned a "success" as well - the workflow didn't fail and it really ought to have done so.
Personally, I'd appreciate a tweak, especially since we do more changes than creations and probably would have gotten the issue flagged sooner if there had been an error generated here.
Thanks!
servicenow-devops-update-change/src/main.js
Line 106 in 862232a
Hi. We had a bad tool token saved to our github secrets last week. (totally our fault). But it exposed something unexpected:
When we were modifying an existing CHG, we got a silent failure in the github workflow log. However, when creating a new CHG with the "servicenow-devops-change" action, we were getting a 403 response.
It looks to me like... maybe the code linked above just skips over 403 errors? There's no output for errors other than 400|401|405|500 and CONNREFUSED. And the github action returned a "success" as well - the workflow didn't fail and it really ought to have done so.
Personally, I'd appreciate a tweak, especially since we do more changes than creations and probably would have gotten the issue flagged sooner if there had been an error generated here.
Thanks!