Change default Content-Disposition type from 'inline' to 'attachment'

Author: C0nquistadore

src/Dibix.Sdk.CodeGeneration/Registration/ControllerDefinitionProvider.cs

@@ -374,7 +374,7 @@ private static bool TryReadFileResponse(JObject action, out ActionFileResponse f
             bool cache = (bool?)cacheProperty?.Value ?? true;
             SourceLocation? indentJson = (bool?)indentJsonProperty?.Value == true ? indentJsonProperty.GetSourceInfo() : null;
             if (!Enum.TryParse((string)fileResponseValue.Property("dispositionType")?.Value, true, out ContentDispositionType dispositionType))
-                dispositionType = ContentDispositionType.Inline;
+                dispositionType = ContentDispositionType.Attachment;
 
             fileResponse = new ActionFileResponse(mediaType, cache, dispositionType, indentJson);
             location = fileResponseProperty.GetSourceInfo();

tests/Dibix.Sdk.Tests.Database/Endpoints/GenericEndpoint.json

@@ -95,8 +95,7 @@
       "fileResponse": {
         "mediaType": "image/*",
         "cache": false,
-        "indentJson": false,
-        "dispositionType": "attachment"
+        "indentJson": false
       },
       "authorization": "none"
     },

tests/Dibix.Sdk.Tests.Database/Endpoints/GenericEndpointReflection.json

@@ -42,7 +42,7 @@
       "fileResponse": {
         "mediaType": "image/*",
         "cache": false,
-        "dispositionType": "attachment"
+        "dispositionType": "inline"
       }
     }
   ]

tests/Dibix.Sdk.Tests/Resources/CodeGeneration/Endpoints_Accessor.cs

@@ -336,7 +336,7 @@ public override void Configure(IHttpApiDiscoveryContext context)
                     action.Method = HttpApiMethod.Get;
                     action.ChildRoute = "Reflection/File/{id}";
                     action.SecuritySchemes.Add("DibixBearer");
-                    action.FileResponse = new HttpFileResponseDefinition(cache: false, dispositionType: ContentDispositionType.Attachment, indentJson: false);
+                    action.FileResponse = new HttpFileResponseDefinition(cache: false, dispositionType: ContentDispositionType.Inline, indentJson: false);
                 });
             });
         }