Validate the name length of BEGIN TRANSACTION statements

Author: C0nquistadore

src/Dibix.Sdk/CodeAnalysis/Rules/NamingConventionSqlCodeAnalysisRule.cs

@@ -24,6 +24,18 @@ protected override void BeginStatement(TSqlScript node)
             this._looseConstraintDeclarations.ReplaceWith(visitor.LooseConstraintDeclarations);
         }
 
+        public override void Visit(BeginTransactionStatement node)
+        {
+            if (node.Name == null)
+                return;
+
+            string name = node.Name.Value;
+            if (name.Length > 32)
+            {
+                Fail(node.Name, $"The identifier that starts with '{name}' is too long. Maximum length is 32.");
+            }
+        }
+
         // Tables
         public override void Visit(CreateTableStatement node)
         {

tests/Dibix.Sdk.Tests.Database/CodeAnalysis/dbx_codeanalysis_error_017.sql

@@ -44,4 +44,12 @@ CREATE TYPE [dbo].[dbx_codeanalysis_udt_error_017_success] AS TABLE ([id] INT NO
 GO
 CREATE PROCEDURE [dbo].[dbx_codeanalysis_error_017_param] @success BIT, @fAiL BIT
 AS
-    PRINT @success + fail
+    PRINT @success + @faiL
+GO
+CREATE PROCEDURE [dbo].[dbx_codeanalysis_error_017_length]
+AS
+    BEGIN TRANSACTION [dbx_codeanalysis_error_017_len_s]
+    ROLLBACK
+
+    BEGIN TRANSACTION [dbx_codeanalysis_error_017_len_fail]
+    ROLLBACK

tests/Dibix.Sdk.Tests/Resources/CodeAnalysis/NamingConventionSqlCodeAnalysisRule.xml

@@ -60,4 +60,9 @@
     message="Function parameter '@fAiL' does not match naming convention '^@[a-z0-9_]+$'. Also make sure the name is all lowercase."
     line="45"
     column="73" />
+  <error
+    ruleid="17"
+    message="The identifier that starts with 'dbx_codeanalysis_error_017_len_fail' is too long. Maximum length is 32."
+    line="54"
+    column="23" />
 </errors>