Always set UseDedicatedTestResultsDirectory to true, because #if CI_BUILD isn't really the desired behavior

Author: C0nquistadore

src/Dibix.Testing/TestBase.cs

@@ -29,7 +29,7 @@ protected TConfiguration Configuration
 
         protected override Task OnTestInitialized()
         {
-            this.Configuration = TestConfigurationLoader.Load<TConfiguration>(this.TestContext);
+            this.Configuration = TestConfigurationLoader.Load<TConfiguration>(base.TestContext);
             return Task.CompletedTask;
         }
     }
@@ -58,17 +58,7 @@ internal TestOutputWriter TestOutputHelper
         protected virtual TextWriter Out => this.TestOutputHelper;
         protected string RunDirectory => this.TestResultComposer.RunDirectory;
         protected string TestDirectory => this.TestResultComposer.TestDirectory;
-
-        /// <summary>
-        /// By default, the test results directory is cleaned up by MSTest, after all tests of a run have passed.
-        /// It might be desired to keep the test output even if all tests have passed, i.E. for investigation purposes.
-        /// Setting this property to true, will store the output in the temp directory, so they are still available after each run.
-        /// </summary>
-#if CI_BUILD
         protected virtual bool UseDedicatedTestResultsDirectory => true;
-#else
-        protected virtual bool UseDedicatedTestResultsDirectory => false;
-#endif
         private TestResultComposer TestResultComposer
         {
             get => SafeGetProperty(ref this._testResultComposer);
@@ -219,8 +209,8 @@ protected virtual void Dispose(bool disposing)
         {
             if (disposing)
             {
-                this.TestOutputHelper?.Dispose();
-                TestResultComposer.Complete();
+                this._testOutputHelper?.Dispose();
+                this._testResultComposer?.Complete();
             }
         }
         #endregion

src/Dibix.Testing/Utilities/TestResultComposer.cs

@@ -6,6 +6,8 @@
 using System.Linq;
 using System.Reflection;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Serialization;
 
 namespace Dibix.Testing
 {
@@ -36,6 +38,9 @@ public TestResultComposer(TestContext testContext, bool useDedicatedTestResultsD
             this._actualDirectory = Path.Combine(this.RunDirectory, ActualDirectoryName);
             this._testRunFiles = new HashSet<string>();
             this._testFiles = new HashSet<string>();
+#if DEBUG
+            this.EnsureTestContextDump();
+#endif
         }
 
         public string AddFile(string fileName)
@@ -136,16 +141,22 @@ private void RegisterFile(string path, bool scopeIsTestRun)
             files.Add(path);
         }
 
-        private void EnsureWinMergeStarter()
+        private void EnsureWinMergeStarter() => AddTestRunFile("winmerge.bat", $@"@echo off
+start winmergeU ""{ExpectedDirectoryName}"" ""{ActualDirectoryName}""");
+        private void EnsureTestContextDump() => AddTestRunFile("TestContext.json", JsonConvert.SerializeObject(this._testContext, new JsonSerializerSettings
+        {
+            Formatting = Formatting.Indented,
+            ContractResolver = new TestContextContractResolver()
+        }));
+
+        private void AddTestRunFile(string fileName, string content)
         {
-            const string fileName = "winmerge.bat";
             string path = Path.Combine(this.RunDirectory, fileName);
 
             if (!this.ShouldRegisterTestRunFile(path))
                 return;
 
-            WriteContentToFile(path, $@"@echo off
-start winmergeU ""{ExpectedDirectoryName}"" ""{ActualDirectoryName}""");
+            WriteContentToFile(path, content);
             this.RegisterFile(path, scopeIsTestRun: true);
         }
 
@@ -225,5 +236,19 @@ public enum EventLogEntryType
             SuccessAudit = 8,
             FailureAudit = 16
         }
+
+        private sealed class TestContextContractResolver : DefaultContractResolver, IContractResolver
+        {
+            protected override JsonObjectContract CreateObjectContract(Type objectType)
+            {
+                JsonObjectContract contract = base.CreateObjectContract(objectType);
+                if (objectType.FullName == "Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.TestContextImplementation")
+                {
+                    // Self referencing loop detected for property 'Context' with type 'Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.TestContextImplementation'. Path ''.
+                    contract.Properties.Remove("Context");
+                }
+                return contract;
+            }
+        }
     }
 }