Validate unmapped contract properties in SELECT

Author: C0nquistadore

src/Dibix.Sdk.CodeGeneration/Parser/StatementOutputParser.cs

@@ -335,6 +335,16 @@ bool isFirstResult
                 if (!(schema is ObjectSchema objectSchema))
                     throw new NotSupportedException($"Unsupported return type for result validation: {returnType.GetType()}");
 
+                foreach (IGrouping<string, OutputColumnResult> duplicateGroups in columnGroup.GroupBy(x => x.ColumnName).Where(x => x.Count() > 1))
+                {
+                    foreach (OutputColumnResult duplicateColumn in duplicateGroups.Skip(1))
+                    {
+                        logger.LogError($"Duplicate column name in SELECT '{duplicateColumn.ColumnName}'", duplicateColumn.ColumnNameSource, returnType.Location.Source);
+                    }
+                }
+
+                ICollection<ObjectSchemaProperty> visitedProperties = [.. objectSchema.Properties.Where(x => IsPrimitiveType(x.Type, schemaRegistry) && !x.Type.IsEnumerable)];
+
                 foreach (OutputColumnResult columnResult in columnGroup)
                 {
                     // Validate alias
@@ -354,6 +364,8 @@ bool isFirstResult
                         continue;
                     }
 
+                    visitedProperties.Remove(property);
+
                     if (!IsPrimitiveType(property.Type, schemaRegistry))
                     {
                         logger.LogError($"Column '{columnResult.ColumnName}' cannot be mapped. Only primitive types are supported.", returnElement.Location.Source, columnResult.ColumnNameSource.StartLine, columnResult.ColumnNameSource.StartColumn);
@@ -365,6 +377,11 @@ bool isFirstResult
                     //if (columnResult.IsNullable.HasValue && columnResult.IsNullable.Value != property.Type.IsNullable)
                     //    logger.LogError(null, $"Nullability of column '{columnResult.ColumnName}' should match the target property", target.Source, columnResult.ColumnNameSource.StartLine, columnResult.ColumnNameSource.StartColumn);
                 }
+
+                foreach (ObjectSchemaProperty property in visitedProperties)
+                {
+                    logger.LogError($"Property '{property.Name}' on type '{schema.FullName}' not mapped", columnGroup[0].PrimarySource, returnType.Location.Source);
+                }
             }
         }
 

src/Dibix.Sdk.Sql/ScriptDomExtensions.cs

@@ -3,6 +3,7 @@
 using System.Collections.ObjectModel;
 using System.Linq;
 using System.Text;
+using Dibix.Sdk.Abstractions;
 using Microsoft.SqlServer.Dac;
 using Microsoft.SqlServer.Dac.Model;
 using Microsoft.SqlServer.TransactSql.ScriptDom;
@@ -11,6 +12,8 @@ namespace Dibix.Sdk.Sql
 {
     public static class ScriptDomExtensions
     {
+        public static void LogError(this ILogger logger, string text, TSqlFragment fragment, string source) => logger.LogMessage(LogCategory.Error, subCategory: null, code: null, text, source, fragment.StartLine, fragment.StartColumn);
+
         public static string Dump(this TSqlFragment fragment)
         {
             StringBuilder sb = new StringBuilder();

tests/Dibix.Sdk.Tests.Database/Dibix.Sdk.Tests.Database.sqlproj

@@ -154,6 +154,7 @@
     <Build Include="Tests\Syntax\dbx_tests_syntax_singleconcreteresult_params_array.sql" />
     <Build Include="Tests\Syntax\dbx_tests_syntax_enum3.sql" />
     <Build Include="Tests\Syntax\dbx_tests_syntax_empty_params_udt.sql" />
+    <Build Include="Tests\Syntax\dbx_tests_syntax_singleconcreteresult_missingcolumn.sql" />
   </ItemGroup>
   <ItemGroup>
     <Folder Include="CodeAnalysis" />

tests/Dibix.Sdk.Tests.Database/Tests/Syntax/dbx_tests_syntax_singleconcreteresult_missingcolumn.sql

@@ -0,0 +1,8 @@
+-- @Return ClrTypes:GenericContract Mode:Single
+CREATE PROCEDURE [dbo].[dbx_tests_syntax_singleconcreteresult_missingcolumn]
+AS
+    SELECT [id]           = 1
+         , [name]         = NULL
+         , [parentid]     = NULL
+         , [role]         = NULL
+         , [creationtime] = NULL

tests/Dibix.Sdk.Tests/CodeGeneration/CodeGenerationTaskTests.cs

@@ -520,16 +520,20 @@ public void Endpoint_WithValidationErrors_Error()
                   , @"Types\dbx_codeanalysis_udt_int.sql"
                   , @"Tests\Syntax\dbx_tests_syntax_empty_params.sql"
                   , @"Tests\Syntax\dbx_tests_syntax_empty_params_udt.sql"
+                  , @"Tests\Syntax\dbx_tests_syntax_singleconcreteresult.sql"
+                  , @"Tests\Syntax\dbx_tests_syntax_singleconcreteresult_missingcolumn.sql"
                 }
               , contracts: new[]
                 {
                     @"Contracts\Direction.json"
+                  , @"Contracts\GenericContract.json"
                   , @"Contracts\Entry.json"
                   , @"Contracts\Request.json"
                 }
               , endpoints: new[] { @"Endpoints\GenericEndpointWithErrors.json" }
               , isEmbedded: false
               , expectedException: @"One or more errors occured during code generation:
+Tests\Syntax\dbx_tests_syntax_singleconcreteresult_missingcolumn.sql(4,12,4,12):error:Property 'ImageUrl' on type 'Dibix.Sdk.Tests.DomainModel.GenericContract' not mapped
 Endpoints\GenericEndpointWithErrors.json(8,15,8,15):error:Unknown property source 'WTF'
 Endpoints\GenericEndpointWithErrors.json(20,20,20,20):error:Property 'X' not found on contract 'Dibix.Sdk.Tests.DomainModel.Request'
 Endpoints\GenericEndpointWithErrors.json(21,23,21,23):error:Property 'Nm' not found on contract 'Dibix.Sdk.Tests.DomainModel.Entry'