Fix error in Dibix.Sdk.Tests.Database

Author: C0nquistadore

tests/Dibix.Sdk.Tests.Database/CodeAnalysis/dbx_codeanalysis_error_042.sql

@@ -11,7 +11,7 @@ BEGIN
     SET ROWCOUNT                          0        -- Fail => Unsupported option => Default is 0
     SET STATISTICS TIME                   ON       -- Fail => Unsupported option
     SET TEXTSIZE                          0        -- Fail => Unsupported option
-    SETUSER                               N'x'     -- Fail => Unsupported option
+    SETUSER                                        -- Fail => Unsupported option
     SET DEADLOCK_PRIORITY                 HIGH     -- Fail => Unsupported setting value
     SET NOCOUNT                           OFF      -- Fail => Unsupported setting value
     SET XACT_ABORT                        OFF      -- Fail => Unsupported setting value

tests/Dibix.Sdk.Tests/CodeAnalysis/SqlCodeAnalysisRuleTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -32,9 +31,14 @@ partial void Execute(string testName)
                                                                              .Select(x => new TaskItem(x.Value) { ["FullPath"] = Path.Combine(DatabaseTestUtility.DatabaseProjectDirectory, x.Value) })
                                                                              .ToArray();
 
+            // master.dacpac is actually required otherwise causes this error:
+            // CodeAnalysis\dbx_codeanalysis_error_002.sql(84,10,84,10):error 71502:Procedure: [dbo].[dbx_codeanalysis_error_002_x] has an unresolved reference to object [dbo].[sp_executesql].
+            // The master.dacpac lies in the VS IDE folder with an installed SSDT, which is not available in CI builds, therefore ignore it for now.
+            ICollection<TaskItem> references = Array.Empty<TaskItem>();
+
             TestLogger logger = new TestLogger(base.Out, distinctErrorLogging: true);
 
-            TSqlModel model = PublicSqlDataSchemaModelLoader.Load(DatabaseTestUtility.ProjectName, DatabaseTestUtility.DatabaseSchemaProviderName, DatabaseTestUtility.ModelCollation, sources, Array.Empty<TaskItem>(), logger);
+            TSqlModel model = PublicSqlDataSchemaModelLoader.Load(DatabaseTestUtility.ProjectName, DatabaseTestUtility.DatabaseSchemaProviderName, DatabaseTestUtility.ModelCollation, sources, references, logger);
             LockEntryManager lockEntryManager = LockEntryManager.Create();
             ISqlCodeAnalysisRuleEngine engine = SqlCodeAnalysisRuleEngine.Create(model, DatabaseTestUtility.ProjectName, new SqlCodeAnalysisConfiguration("dbx"), false, lockEntryManager, logger);
             IEnumerable<SqlCodeAnalysisError> errors = engine.Analyze(violationScriptPath, ruleInstance);

tests/Dibix.Sdk.Tests/Resources/CodeAnalysis/SetStatementSqlCodeAnalysisRule.xml

@@ -47,7 +47,7 @@
     column="5" />
   <error
     ruleid="42"
-    message="Unsupported SET statement: SETUSER N'x'"
+    message="Unsupported SET statement: SETUSER"
     line="14"
     column="5" />
   <error