Fix CoverageService: only analyze classes present in exec data to avoid duplicate class errors

Author: jcompagner

plugins/com.github.gradusnikov.eclipse.plugin.assistai.main/src/com/github/gradusnikov/eclipse/assistai/mcp/services/CoverageService.java

@@ -6,7 +6,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
+import java.util.HashSet;
 import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
 
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.ResourcesPlugin;
@@ -188,28 +191,85 @@ private String analyzeCoverage( String execFilePath, String projectName ) throws
             reader.read();
         }
 
+        Set<String> executedClassNames = executionDataStore.getContents().stream()
+            .map( data -> data.getName() )
+            .collect( Collectors.toSet() );
+
+        if ( executedClassNames.isEmpty() )
+        {
+            return "\n--- Coverage ---\nNo execution data found in coverage file.\n";
+        }
+
         CoverageBuilder coverageBuilder = new CoverageBuilder();
         Analyzer analyzer = new Analyzer( executionDataStore, coverageBuilder );
+        Set<String> analyzedClasses = new HashSet<>();
 
         IProject[] allProjects = ResourcesPlugin.getWorkspace().getRoot().getProjects();
         for ( IProject project : allProjects )
         {
-            if ( !project.isOpen() || !project.hasNature( JavaCore.NATURE_ID ) )
+            try
             {
-                continue;
+                if ( !project.isOpen() || !project.hasNature( JavaCore.NATURE_ID ) )
+                {
+                    continue;
+                }
+                IJavaProject javaProject = JavaCore.create( project );
+                File outputLocation = project.getLocation().append(
+                    javaProject.getOutputLocation().removeFirstSegments( 1 ) ).toFile();
+                if ( !outputLocation.exists() )
+                {
+                    continue;
+                }
+                analyzeMatchingClasses( outputLocation, outputLocation, executedClassNames, analyzedClasses, analyzer );
             }
-            IJavaProject javaProject = JavaCore.create( project );
-            File outputLocation = project.getLocation().append(
-                javaProject.getOutputLocation().removeFirstSegments( 1 ) ).toFile();
-            if ( outputLocation.exists() )
+            catch ( Exception e )
             {
-                analyzer.analyzeAll( outputLocation );
+                if ( logger != null )
+                {
+                    logger.warn( "Skipping project '" + project.getName() + "' during coverage analysis: " + e.getMessage() );
+                }
             }
         }
 
         return formatReport( coverageBuilder, projectName );
     }
 
+    private void analyzeMatchingClasses( File root, File dir, Set<String> executedClassNames,
+        Set<String> analyzedClasses, Analyzer analyzer ) throws IOException
+    {
+        File[] files = dir.listFiles();
+        if ( files == null )
+        {
+            return;
+        }
+        for ( File file : files )
+        {
+            if ( file.isDirectory() )
+            {
+                analyzeMatchingClasses( root, file, executedClassNames, analyzedClasses, analyzer );
+            }
+            else if ( file.getName().endsWith( ".class" ) )
+            {
+                String relativePath = root.toPath().relativize( file.toPath() ).toString().replace( '\\', '/' );
+                String className = relativePath.substring( 0, relativePath.length() - 6 );
+                if ( executedClassNames.contains( className ) && analyzedClasses.add( className ) )
+                {
+                    try ( FileInputStream fis = new FileInputStream( file ) )
+                    {
+                        analyzer.analyzeAll( fis, className );
+                    }
+                    catch ( Exception e )
+                    {
+                        if ( logger != null )
+                        {
+                            logger.warn( "Skipping class '" + className + "': " + e.getMessage() );
+                        }
+                    }
+                }
+            }
+        }
+    }
+
     private String formatReport( CoverageBuilder coverageBuilder, String projectName )
     {
         StringBuilder sb = new StringBuilder();

tests/com.github.gradusnikov.eclipse.plugin.assistai.main.tests/src/com/github/gradusnikov/eclipse/plugin/assistai/mcp/services/CoverageServiceTest.java

@@ -282,7 +282,7 @@ public void testFindLatestCoverageFile_returnsNullOrPath()
 
     @Test
     @Order( 9 )
-    public void testFormatCoverageInfo_withValidExecFile_andProject_returnsCoverageReport() throws Exception
+    public void testFormatCoverageInfo_withEmptyExecFile_andProject_returnsNoDataMessage() throws Exception
     {
         assumeTrue( coverageService.isCoverageAvailable(),
             "Skipping: EclEmma/JaCoCo not installed" );
@@ -297,8 +297,8 @@ public void testFormatCoverageInfo_withValidExecFile_andProject_returnsCoverageR
         try
         {
             String result = coverageService.formatCoverageInfo( tempExec.toString(), TEST_PROJECT_NAME );
-            assertTrue( result.contains( "--- Coverage Report ---" ) );
-            assertTrue( result.contains( "All classes fully covered." ) || result.contains( "Classes with incomplete coverage:" ) );
+            assertTrue( result.contains( "--- Coverage ---" ) );
+            assertTrue( result.contains( "No execution data found" ) );
         }
         finally
         {