Skip to content

Gradient Error in Chapter6 RNN_DLFS ipynb file. #21

Description

@eurush

Error in class RNNNode():'s def backward() function. Chain rule suggest, gradient from the $t+1$ must be added as well.

  • Current version: dh = np.dot(X_out_grad, params_dict['W_v']['value'].T)
  • Correct version: dh = np.dot(X_out_grad, params_dict['W_v']['value'].T) + H_out_grad

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions