-
Notifications
You must be signed in to change notification settings - Fork 23
feat(Flydigi): Add support for flydigi vader 3/4 pro #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(Flydigi): Add support for flydigi vader 3/4 pro #308
Conversation
75aa6d7
to
4fac759
Compare
@Fabianoshz I think instead of doing all those remappings in the InputPlumber CapabilityMap, the xpad patch you are using should be updated so the Flydigi paddles match the Xbox Elite paddle mappings.
|
@blindedone1458 Thanks, with this patch, I see that the paddle buttons is working (via steam). Apex 4 But what to do about the Share button? Because Series controllers have it. |
@blindedone1458 tbh I've set this up months ago and didn't bothered after that, having them being recognized a xbox elite could be good but it depends on ends up being merged on xpad. My guess is that if you patch works we could maybe close this in favor of that and people can revisit this in the future in case the original patch gets merged for whatever reason. |
For the Share button, are you referring to the Circle button? I honestly hadn't even considered the button as something that could be mapped originally (since it wasn't really doing much beyond controller functions) without Flydigi mapping software. I just made a change to the xpad patch to map it to a Share button:
|
As for your PR, I think it is good to have but just that the CapabilityMap doesn't need all those Mappings in it. Could have a basic mapping in it for the C and Z buttons since the Xbox Elite / Series controllers don't have a C or Z:
|
Can someone post a picture of the controller with all the buttons labeled for context? |
@blindedone1458 Yes, that's correct. I think we need to try mapping it to the "Share" button. cc @pastaq This is necessary for taking screenshots and full mapping of the Xbox Elite controller. |
Ohh... I forgot. The "Share" button only exists on the Xbox Series controller. On the Xbox Elite 2 controller, this button switches profiles. I have not used the controller in a long time... But at the same time, when you look at the Steam interface you can see this button. But will cool mapping FN to it if possible. |
@blindedone1458 thanks! It works #308 (comment) Now Steam recognizes |
@pastaq a gamepad with paddle button layout for context. I have marked it in orange. |
Interesting. Buttons C and Z are going to be a challenge as there isn't a normal function for them on modern controllers. They are part of the original dinput spec and produce valid codes (BTN_C/BTN_Z). The original Xbox controller has them as well as things like the sidewinder and the Sega Saturn controller. They have fallen out of favor since the 360 came out. It feels incorrect to map them to happy trigger. We also haven't fully decided what to do with them in InputPlumber as they fit into a weird spot where they aren't really a standard capability or button like abxy are, despite being an extension of that. |
It seems that these buttons (C, Z) need to be connected to keyboard events in the current situation. E.g. Home, End |
The current solution for Apex 4 meets 90% of the needs. The remaining 10% is the gyroscope. Also ability to change at least the backlight color, but that's another story. |
Hi, everyone! I have a Vader 3 Pro and I wasn't able to make it work as an Elite Controller. I have already patched Does anyone have any clue on how I can debug it or make it work? I have |
@italoghost when you run evtest there is some info it prints out at the beginning with things like the name of the device and it's vid/PID, enabled buttons, can you post that? It should look something like this If so, the vid/pid in the patch and the inputplumber config will need to be changed. |
I wasn't aware this thing had gyro. Can you install |
X-Input I forgot that when a gamepad is connected to a computer using XInput, it works at the firmware level. Depending on the settings, the gyroscope movements are mapped to the left or right stick. I've now activated the gyro using official flydigi software and tested it on both Linux and Windows systems. Everything works as expected and similar. The gamepad in XInput mode doesn't need any additional adjustments.
D-Input (via dongle) It looks like the gyroscope is defined as a mouse device when connected via D-Input. hid-recorder result
|
It seems that the My current worked solution.
Sources: /usr/share/inputplumber/devices/59-flydigi-vader.yaml
NOTE: After patching the |
evtest (apex 4 via dongle)
lsusb -v -d 045e:028e (apex 4 via dongle)
|
Thanks, @belozer! After removing the Here is the output of
|
I also would like to report that the C and Z buttons have stopped working, as expected. If you need to test the gyro with my specific controller, I can help with the data/logs! |
@italoghost You ran the evtest after replacing the gamepad via the InputPlumber. Could you please stop the InputPlumber. sudo systemctl stop inputplumber and retrieve the evtest report? It would also be good to add the lsusb output result (I need to understand how it differs from Apex 4 and whether we can already somehow determine which is Apex and which is Vader) lsusb -v -d 045e:028e After that, you can run the InputPlumber again. sudo systemctl start inputplumber |
Sure, @belozer! Here it is:
|
Hi! Since the support for the Vader 4 Pro was added to the latest release, is the there any chances that this PR will be merged as well? |
This needs to be updated to use a capability map v2 and ensure it matches the same capability translation that the hidraw version uses. You can add an entry to the existing config for that instead of duplicating it, just add a comment to the entry that it's for xinput mode. |
Sorry, how do I do that? And by briefly looking at the commit c5f115f, the |
This should add support for both flydigi vader 3 and 4.
Fixes #208