Update Axs15231bDisplay.cpp

Author: Shadowtrance

Drivers/Axs15231b/Source/Axs15231bDisplay.cpp

@@ -200,15 +200,15 @@ bool Axs15231bDisplay::createPanelHandle(esp_lcd_panel_io_handle_t ioHandle, esp
 
     if (configuration->tePin > 0)
     {
-        tear_ctx = malloc(sizeof(lcd_tear_t));
-        //ESP_GOTO_ON_FALSE(tear_ctx != NULL, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for tear_ctx allocation!");
+        tear_ctx = (lcd_tear_t*)malloc(sizeof(lcd_tear_t));
+        ESP_GOTO_ON_FALSE(tear_ctx != nullptr, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for tear_ctx allocation!");
 
         te_v_sync_sem = xSemaphoreCreateCounting(1, 0);
-        //ESP_GOTO_ON_FALSE(te_v_sync_sem, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for te_v_sync_sem Semaphore.");
+        ESP_GOTO_ON_FALSE(te_v_sync_sem, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for te_v_sync_sem Semaphore.");
         tear_ctx->te_v_sync_sem = te_v_sync_sem;
 
         te_catch_sem = xSemaphoreCreateCounting(1, 0);
-        //ESP_GOTO_ON_FALSE(te_catch_sem, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for te_catch_sem Semaphore.");
+        ESP_GOTO_ON_FALSE(te_catch_sem, ESP_ERR_NO_MEM, err, TAG, "Not enough memory for te_catch_sem Semaphore.");
         tear_ctx->te_catch_sem = te_catch_sem;
 
         tear_ctx->time_Tvdl = time_Tvdl;
@@ -217,23 +217,48 @@ bool Axs15231bDisplay::createPanelHandle(esp_lcd_panel_io_handle_t ioHandle, esp
         tear_ctx->lock.count = 0;
 
         const gpio_config_t te_detect_cfg = {
-            .intr_type = GPIO_INTR_NEGEDGE,
-            .mode = GPIO_MODE_INPUT,
             .pin_bit_mask = BIT64(configuration->tePin),
+            .mode = GPIO_MODE_INPUT,
+            .pull_up_en = GPIO_PULLUP_ENABLE,
             .pull_down_en = GPIO_PULLDOWN_DISABLE,
-            .pull_up_en = GPIO_PULLUP_ENABLE};
+            .intr_type = tear_intr_type
+        };
 
         ESP_ERROR_CHECK(gpio_config(&te_detect_cfg));
         gpio_install_isr_service(0);
         ESP_ERROR_CHECK(gpio_isr_handler_add(configuration->tePin, display_tear_interrupt, tear_ctx));
 
-        BaseType_t res = xTaskCreate(display_sync_task, "Tear Task", 2048, tear_ctx, 4, NULL);
-        //ESP_GOTO_ON_FALSE(res == pdPASS, ESP_FAIL, err, TAG, "Create Sync Task Fail!");
+        BaseType_t res = xTaskCreate(display_sync_task, "Tear Task", 2048, tear_ctx, 4, nullptr);
+        ESP_GOTO_ON_FALSE(res == pdPASS, ESP_FAIL, err, TAG, "Create Sync Task Fail!");
     }
 
-    lv_display_add_event_cb(display, display_sync_cb, LV_EVENT_FLUSH_START, tear_ctx);
+    lv_display_add_event_cb(lvglDisplay, display_sync_cb, LV_EVENT_FLUSH_START, tear_ctx);
 
     return true;
+
+err:
+    if (te_v_sync_sem)
+    {
+        vSemaphoreDelete(te_v_sync_sem);
+    }
+    if (te_catch_sem)
+    {
+        vSemaphoreDelete(te_catch_sem);
+    }
+    if (tear_ctx)
+    {
+        free(tear_ctx);
+    }
+    if (panelHandle)
+    {
+        esp_lcd_panel_del(panelHandle);
+    }
+    if (ioHandle)
+    {
+        esp_lcd_panel_io_del(ioHandle);
+    }
+    spi_bus_free(SPI2_HOST);
+    return false;
 }
 
 lvgl_port_display_cfg_t Axs15231bDisplay::getLvglPortDisplayConfig(esp_lcd_panel_io_handle_t ioHandle, esp_lcd_panel_handle_t panelHandle) {