round...again

Author: Shadowtrance

Boards/WaveshareS3TouchLcd128/Source/WaveshareS3TouchLcd128.cpp

@@ -17,7 +17,7 @@ static DeviceVector createDevices() {
 }
 
 static bool initBoot() {
-    return driver::pwmbacklight::init(GPIO_NUM_2, 200);
+    return driver::pwmbacklight::init(GPIO_NUM_2, 256);
 }
 
 extern const Configuration waveshare_s3_touch_lcd_128 = {

Boards/WaveshareS3TouchLcd128/Source/devices/Display.cpp

@@ -26,7 +26,6 @@ std::shared_ptr<tt::hal::display::DisplayDevice> createDisplay() {
         SPI2_HOST,
         GPIO_NUM_9,
         GPIO_NUM_8,
-        GPIO_NUM_14,
         240,
         240,
         touch,
@@ -38,6 +37,7 @@ std::shared_ptr<tt::hal::display::DisplayDevice> createDisplay() {
         LCD_RGB_ELEMENT_ORDER_BGR
     );
 
+    configuration->resetPin = GPIO_NUM_14;
     configuration->backlightDutyFunction = driver::pwmbacklight::setBacklightDuty;
 
     auto display = std::make_shared<Gc9a01Display>(std::move(configuration));

Drivers/GC9A01/Source/Gc9a01Display.h

@@ -25,7 +25,6 @@ class Gc9a01Display final : public EspLcdDisplay {
             spi_host_device_t spiHostDevice,
             gpio_num_t csPin,
             gpio_num_t dcPin,
-            gpio_num_t resetPin,
             unsigned int horizontalResolution,
             unsigned int verticalResolution,
             std::shared_ptr<tt::hal::touch::TouchDevice> touch,
@@ -56,7 +55,7 @@ class Gc9a01Display final : public EspLcdDisplay {
         spi_host_device_t spiHostDevice;
         gpio_num_t csPin;
         gpio_num_t dcPin;
-        gpio_num_t resetPin;
+        gpio_num_t resetPin = GPIO_NUM_NC;
         unsigned int pixelClockFrequency = 80'000'000; // Hertz
         size_t transactionQueueDepth = 10;
         unsigned int horizontalResolution;