Skip to content

Commit 3bab451

Browse files
authored
Merge pull request #5 from Shakya47/fix/remove-logs
fix: remove debug logs, bump to 0.1.5, and harden CI filters
2 parents 525c65f + d4b4f81 commit 3bab451

5 files changed

Lines changed: 12 additions & 7 deletions

File tree

.changeset/remove-debug-logs.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@pip-it-up/core": patch
3+
"@pip-it-up/react": patch
4+
---
5+
6+
Remove debug console logs from production builds.

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,16 @@ jobs:
3333
run: pnpm install --frozen-lockfile
3434

3535
- name: Typecheck
36-
run: pnpm typecheck
36+
run: pnpm exec turbo run typecheck --filter='./packages/*'
3737

3838
- name: Lint
39-
run: pnpm lint
39+
run: pnpm exec turbo run lint --filter='./packages/*'
4040

4141
- name: Test
4242
run: pnpm exec turbo run test --filter='./packages/*' -- --coverage
4343

4444
- name: Build
45-
run: pnpm build
45+
run: pnpm exec turbo run build --filter='./packages/*'
4646

4747
- name: Upload coverage
4848
uses: actions/upload-artifact@v4

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
run: pnpm install --frozen-lockfile
3636

3737
- name: Build
38-
run: pnpm build
38+
run: pnpm exec turbo run build --filter='./packages/*'
3939

4040
- name: Create Release Pull Request or Publish
4141
id: changesets

packages/core/src/createPip.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,6 @@ export const createPip = (options: PipOptions = {}): PipInstance => {
229229
},
230230
};
231231

232-
console.log('[createPip] Creating instance with setDefaultElements:', typeof instance.setDefaultElements);
232+
233233
return instance;
234234
};

packages/react/src/PipWrapper.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,7 @@ export const PipWrapper = forwardRef<HTMLElement, PipWrapperProps>((props, ref)
116116
);
117117

118118
useLayoutEffect(() => {
119-
console.log('[PipWrapper] instance:', instance);
120-
console.log('[PipWrapper] instance.setDefaultElements:', typeof instance.setDefaultElements);
119+
121120

122121
if (typeof instance.setDefaultElements === 'function') {
123122
instance.setDefaultElements({

0 commit comments

Comments
 (0)