Remove SOAP_FUNCTIONS_ALL for 8.4 compatibility if safe to do

[alanseiden]

The SOAP_FUNCTIONS_ALL constant was deprecated in PHP 8.4:
php/php-src@42497c1

Would it be fairly safe (not harm PHP 7-8.3 applications) to remove reference to SOAP_FUNCTIONS_ALL here:
https://github.com/Shardj/zf1-future/blob/master/library/Zend/Soap/Server.php
and here:
https://github.com/Shardj/zf1-future/blob/master/tests/Zend/Soap/ServerTest.php

I don't see the purpose for SOAP_FUNCTIONS_ALL but would be interested to know if anyone found it essential.

[develart-projects]

If someone is using the constant, it will fail after this removal. Maybe the best approach would be to detect it and if not present, then set it?

[NattyNarwhal]

i.e. something like this?

diff --git a/library/Zend/Soap/Server.php b/library/Zend/Soap/Server.php
index 7ccd566e5..447dd92ef 100644
--- a/library/Zend/Soap/Server.php
+++ b/library/Zend/Soap/Server.php
@@ -544,8 +544,8 @@ class Zend_Soap_Server implements Zend_Server_Interface
      */
     public function addFunction($function, $namespace = '')
     {
-        // Bail early if set to SOAP_FUNCTIONS_ALL
-        if ($this->_functions == SOAP_FUNCTIONS_ALL) {
+        // Bail early if set to SOAP_FUNCTIONS_ALL (deprecated in 8.4)
+        if (version_compare(PHP_VERSION, "8.4.0", "<") && $this->_functions == SOAP_FUNCTIONS_ALL) {
             return $this;
         }
 
@@ -561,7 +561,7 @@ class Zend_Soap_Server implements Zend_Server_Interface
             $this->_functions = array_merge($this->_functions, $function);
         } elseif (is_string($function) && function_exists($function)) {
             $this->_functions[] = $function;
-        } elseif ($function == SOAP_FUNCTIONS_ALL) {
+        } elseif (version_compare(PHP_VERSION, "8.4.0", "<") && $function == SOAP_FUNCTIONS_ALL) {
             $this->_functions = SOAP_FUNCTIONS_ALL;
         } else {
             require_once 'Zend/Soap/Server/Exception.php';
diff --git a/tests/Zend/Soap/ServerTest.php b/tests/Zend/Soap/ServerTest.php
index cc89aaefb..2b66a6f19 100644
--- a/tests/Zend/Soap/ServerTest.php
+++ b/tests/Zend/Soap/ServerTest.php
@@ -356,6 +356,11 @@ class Zend_Soap_ServerTest extends TestCase
 
     public function testAddAllFunctionsSoapConstant()
     {
+        if (version_compare(PHP_VERSION, "8.4.0", ">=")) {
+            $this->markTestSkipped("SOAP_FUNCTIONS_ALL deprecated in PHP 8.4");
+            return;
+        }
+
         $server = new Zend_Soap_Server();
 
         // SOAP_FUNCTIONS_ALL as a value should pass

(edit: or using @ to just squelch the deprecation, only good on 8.x)

[develart-projects]

Something like that, but probably from v9 of PHP, because deprecated != not working :)