Skip to content

Commit 86c9307

Browse files
author
Aegis-AI
committed
ci: update mlx-swift submodule to latest main in integration tests
Both ci.yml and downstream_integration.yml check out SwiftLM with submodules: recursive, which pins mlx-swift to SwiftLM's submodule commit. When mlx-swift-lm PRs depend on new mlx-swift APIs (e.g. preadIntoOffset from mlx-swift#10), the build fails because the submodule pin is stale. Fix: after replacing mlx-swift-lm with the PR checkout, also pull mlx-swift to latest origin/main so new APIs are available.
1 parent c68d007 commit 86c9307

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ jobs:
123123
# Replace the local submodule with the actively checked out code
124124
rm -rf mlx-swift-lm
125125
cp -r ../mlx-swift-lm .
126+
127+
- name: Update mlx-swift submodule to latest main
128+
run: |
129+
cd SwiftLM/mlx-swift
130+
git fetch origin main
131+
git checkout origin/main
126132
127133
- name: Build SwiftLM
128134
run: |

.github/workflows/downstream_integration.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,14 @@ jobs:
3333
mkdir -p SwiftLM/mlx-swift-lm
3434
find . -mindepth 1 -maxdepth 1 ! -name "SwiftLM" -exec cp -r {} SwiftLM/mlx-swift-lm/ \;
3535
36+
- name: Update mlx-swift submodule to latest main
37+
# SwiftLM's mlx-swift submodule pin may lag behind main.
38+
# Pull latest so new APIs are available for the build.
39+
run: |
40+
cd SwiftLM/mlx-swift
41+
git fetch origin main
42+
git checkout origin/main
43+
3644
- name: Install Metal Toolchain
3745
run: xcodebuild -downloadComponent MetalToolchain || true
3846

0 commit comments

Comments
 (0)