Skip to content

Commit f5720b4

Browse files
author
Sélim Haddioui
committed
fix(package-manager): propagate progress callback to PushAsync for detailed upload progress
Previously, InstallPackageAsync did not forward the progress reporter to PushAsync, causing only 0% and 100% events during the Uploading phase. Now, progress updates are correctly propagated for granular feedback during package installation.
1 parent 48eda37 commit f5720b4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

AdvancedSharpAdbClient/DeviceCommands/PackageManager.Async.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ protected virtual async Task<string> SyncPackageToDeviceAsync(string localFilePa
611611
Action<SyncProgressChangedEventArgs>? progress = callback == null ? null : args => callback.Invoke(localFilePath, args);
612612

613613
// As C# can't use octal, the octal literal 666 (rw-Permission) is here converted to decimal (438)
614-
await sync.PushAsync(stream, remoteFilePath, UnixFileStatus.DefaultFileMode, File.GetLastWriteTime(localFilePath), null, cancellationToken).ConfigureAwait(false);
614+
await sync.PushAsync(stream, remoteFilePath, UnixFileStatus.DefaultFileMode, File.GetLastWriteTime(localFilePath), progress, cancellationToken).ConfigureAwait(false);
615615
}
616616

617617
return remoteFilePath;

0 commit comments

Comments
 (0)