Merge pull request #282 from SheetMetalConnect/claude/find-perf-issues-mjidyjjjgoewtkst-TJrJ3

SheetMetalConnect · web-flow · commit 156751967b13 · 2025-12-29T10:43:18.000+01:00
Find performance issues
diff --git a/src/hooks/useJobIssues.ts b/src/hooks/useJobIssues.ts
@@ -58,15 +58,17 @@ export function useJobIssues(jobId: string | undefined) {
 
     fetchIssueSummary();
 
-    // Subscribe to changes in issues
-    const subscription = supabase
+    // Subscribe to changes in issues - filter by status to reduce callback frequency
+    // Note: Can't filter by job_id directly since issues link through operations
+    const channel = supabase
       .channel(`job-issues-${jobId}`)
       .on(
         'postgres_changes',
         {
           event: '*',
           schema: 'public',
           table: 'issues',
+          filter: 'status=eq.pending',
         },
         () => {
           fetchIssueSummary();
@@ -75,7 +77,7 @@ export function useJobIssues(jobId: string | undefined) {
       .subscribe();
 
     return () => {
-      subscription.unsubscribe();
+      supabase.removeChannel(channel);
     };
   }, [jobId]);
 
diff --git a/src/hooks/useOEEMetrics.ts b/src/hooks/useOEEMetrics.ts
@@ -49,7 +49,7 @@ export function useOEEMetrics(dateRange: number = 30) {
       const startDate = subDays(new Date(), dateRange).toISOString();
       const now = new Date();
 
-      // Fetch operations with cell info
+      // Fetch operations with cell info - removed unused capacity_hours_per_day
       const { data: operations, error: opsError } = await supabase
         .from("operations")
         .select(`
@@ -61,7 +61,7 @@ export function useOEEMetrics(dateRange: number = 30) {
           status,
           completed_at,
           cell_id,
-          cells(name, capacity_hours_per_day)
+          cells(name)
         `)
         .eq("tenant_id", profile.tenant_id)
         .gte("updated_at", startDate);
@@ -184,9 +184,10 @@ export function useOEEMetrics(dateRange: number = 30) {
         }
       });
 
-      // Add quality data to cells
+      // Add quality data to cells - use Map for O(1) lookups instead of O(n) find
+      const operationMap = new Map(operations?.map(o => [o.id, o]) || []);
       quantities?.forEach(q => {
-        const op = operations?.find(o => o.id === q.operation_id);
+        const op = operationMap.get(q.operation_id);
         if (op?.cells?.name) {
           const current = cellMap.get(op.cells.name);
           if (current) {
diff --git a/src/hooks/usePartIssues.ts b/src/hooks/usePartIssues.ts
@@ -58,15 +58,17 @@ export function usePartIssues(partId: string | undefined) {
 
     fetchIssueSummary();
 
-    // Subscribe to changes in issues
-    const subscription = supabase
+    // Subscribe to changes in issues - filter by status to reduce callback frequency
+    // Note: Can't filter by part_id directly since issues link through operations
+    const channel = supabase
       .channel(`part-issues-${partId}`)
       .on(
         'postgres_changes',
         {
           event: '*',
           schema: 'public',
           table: 'issues',
+          filter: 'status=eq.pending',
         },
         () => {
           fetchIssueSummary();
@@ -75,7 +77,7 @@ export function usePartIssues(partId: string | undefined) {
       .subscribe();
 
     return () => {
-      subscription.unsubscribe();
+      supabase.removeChannel(channel);
     };
   }, [partId]);
 
diff --git a/src/hooks/usePendingIssuesCount.ts b/src/hooks/usePendingIssuesCount.ts
@@ -10,7 +10,7 @@ export function usePendingIssuesCount() {
     queryFn: async () => {
       const { count, error } = await supabase
         .from('issues')
-        .select('*', { count: 'exact', head: true })
+        .select('id', { count: 'exact', head: true })
         .eq('status', 'pending');
 
       if (error) throw error;
diff --git a/src/hooks/useQualityMetrics.ts b/src/hooks/useQualityMetrics.ts
@@ -91,11 +91,17 @@ export function useQualityMetrics() {
 
       if (issuesError) throw issuesError;
 
-      // Calculate production totals
-      const totalProduced = quantities?.reduce((sum, q) => sum + (q.quantity_produced || 0), 0) || 0;
-      const totalGood = quantities?.reduce((sum, q) => sum + (q.quantity_good || 0), 0) || 0;
-      const totalScrap = quantities?.reduce((sum, q) => sum + (q.quantity_scrap || 0), 0) || 0;
-      const totalRework = quantities?.reduce((sum, q) => sum + (q.quantity_rework || 0), 0) || 0;
+      // Calculate production totals in single pass instead of 4 separate reduces
+      const totals = quantities?.reduce(
+        (acc, q) => ({
+          produced: acc.produced + (q.quantity_produced || 0),
+          good: acc.good + (q.quantity_good || 0),
+          scrap: acc.scrap + (q.quantity_scrap || 0),
+          rework: acc.rework + (q.quantity_rework || 0),
+        }),
+        { produced: 0, good: 0, scrap: 0, rework: 0 }
+      ) || { produced: 0, good: 0, scrap: 0, rework: 0 };
+      const { produced: totalProduced, good: totalGood, scrap: totalScrap, rework: totalRework } = totals;
 
       // Calculate yield metrics
       const overallYield = totalProduced > 0 ? (totalGood / totalProduced) * 100 : 100;
@@ -142,18 +148,35 @@ export function useQualityMetrics() {
         .sort((a, b) => b.quantity - a.quantity)
         .slice(0, 10);
 
-      // Calculate issue metrics
+      // Calculate issue metrics in single pass instead of 9 separate filters
+      const issueCounts = issues?.reduce(
+        (acc, i) => {
+          // Count by status
+          if (i.status === "pending") acc.pending++;
+          else if (i.status === "approved") acc.approved++;
+          else if (i.status === "rejected") acc.rejected++;
+          else if (i.status === "closed") acc.closed++;
+          // Count by severity
+          if (i.severity === "critical") acc.critical++;
+          else if (i.severity === "high") acc.high++;
+          else if (i.severity === "medium") acc.medium++;
+          else if (i.severity === "low") acc.low++;
+          return acc;
+        },
+        { pending: 0, approved: 0, rejected: 0, closed: 0, critical: 0, high: 0, medium: 0, low: 0 }
+      ) || { pending: 0, approved: 0, rejected: 0, closed: 0, critical: 0, high: 0, medium: 0, low: 0 };
+
       const issueMetrics = {
         total: issues?.length || 0,
-        pending: issues?.filter((i) => i.status === "pending").length || 0,
-        approved: issues?.filter((i) => i.status === "approved").length || 0,
-        rejected: issues?.filter((i) => i.status === "rejected").length || 0,
-        closed: issues?.filter((i) => i.status === "closed").length || 0,
+        pending: issueCounts.pending,
+        approved: issueCounts.approved,
+        rejected: issueCounts.rejected,
+        closed: issueCounts.closed,
         bySeverity: {
-          critical: issues?.filter((i) => i.severity === "critical").length || 0,
-          high: issues?.filter((i) => i.severity === "high").length || 0,
-          medium: issues?.filter((i) => i.severity === "medium").length || 0,
-          low: issues?.filter((i) => i.severity === "low").length || 0,
+          critical: issueCounts.critical,
+          high: issueCounts.high,
+          medium: issueCounts.medium,
+          low: issueCounts.low,
         },
       };
 
@@ -186,10 +209,10 @@ export function useScrapReasonUsage() {
         throw new Error("No tenant ID");
       }
 
-      // Fetch all scrap reasons
+      // Fetch all scrap reasons - only fields we need
       const { data: reasons, error: reasonsError } = await supabase
         .from("scrap_reasons")
-        .select("*")
+        .select("id, code, description, category, active")
         .eq("tenant_id", profile.tenant_id)
         .order("code");
 
diff --git a/src/hooks/useRealtimeSubscription.ts b/src/hooks/useRealtimeSubscription.ts
@@ -186,7 +186,7 @@ export function useRealtimeSubscription(options: RealtimeSubscriptionOptions): v
         operation: 'useRealtimeSubscription',
         channelName,
       });
-      channel.unsubscribe();
+      supabase.removeChannel(channel);
     };
   }, [channelName, tables, enabled, debounceMs, includePayload, debouncedCallback]);
 }
diff --git a/src/pages/admin/Parts.tsx b/src/pages/admin/Parts.tsx
@@ -104,14 +104,9 @@ export default function Parts() {
       const { data, error } = await query;
       if (error) throw error;
 
-      // Check which parts have children
-      const { data: allChildRelations } = await supabase
-        .from("parts")
-        .select("parent_part_id")
-        .not("parent_part_id", "is", null);
-
+      // Build children set from already-fetched data (no second query needed)
       const partsWithChildren = new Set(
-        allChildRelations?.map((p) => p.parent_part_id) || [],
+        data?.filter((p: any) => p.parent_part_id).map((p: any) => p.parent_part_id) || [],
       );
 
       return data.map((part: any) => {

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export function useRealtimeSubscription(options: RealtimeSubscriptionOptions): v`
`186`	`186`	`operation: 'useRealtimeSubscription',`
`187`	`187`	`channelName,`
`188`	`188`	`});`
`189`		`- channel.unsubscribe();`
	`189`	`+ supabase.removeChannel(channel);`
`190`	`190`	`};`
`191`	`191`	`}, [channelName, tables, enabled, debounceMs, includePayload, debouncedCallback]);`
`192`	`192`	`}`