Skip to content

Commit 61f1998

Browse files
committed
fix: review and improve CI/CD setup
- ci.yml: Remove dev branch reference (using Lovable for dev) - ci.yml: Use PROD secrets for build verification - Dockerfile: Add ENV declarations so Vite picks up build args - README: Add CI/CD section with deployment environments table - README: Link to CICD_DEPLOYMENT_PLAN.md in documentation list
1 parent 8eb121a commit 61f1998

File tree

3 files changed

+23
-9
lines changed

3 files changed

+23
-9
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: CI
22

33
on:
44
pull_request:
5-
branches: [main, dev]
5+
branches: [main]
66

77
jobs:
88
lint-and-typecheck:
@@ -45,8 +45,8 @@ jobs:
4545
- name: Build
4646
run: npm run build
4747
env:
48-
VITE_SUPABASE_URL: ${{ secrets.VITE_SUPABASE_URL_DEV }}
49-
VITE_SUPABASE_PUBLISHABLE_KEY: ${{ secrets.VITE_SUPABASE_ANON_KEY_DEV }}
48+
VITE_SUPABASE_URL: ${{ secrets.VITE_SUPABASE_URL_PROD }}
49+
VITE_SUPABASE_PUBLISHABLE_KEY: ${{ secrets.VITE_SUPABASE_ANON_KEY_PROD }}
5050

5151
test:
5252
name: Test

Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ COPY . .
1616
ARG VITE_SUPABASE_URL
1717
ARG VITE_SUPABASE_PUBLISHABLE_KEY
1818

19+
# Set as environment variables for Vite build
20+
ENV VITE_SUPABASE_URL=$VITE_SUPABASE_URL
21+
ENV VITE_SUPABASE_PUBLISHABLE_KEY=$VITE_SUPABASE_PUBLISHABLE_KEY
22+
1923
# Build the app
2024
RUN npm run build
2125

README.md

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ Comprehensive documentation is available in the `/docs` folder:
281281
- **[EDGE_FUNCTIONS_SETUP.md](docs/EDGE_FUNCTIONS_SETUP.md)** - Edge Functions guide
282282
- **[INTEGRATIONS_MARKETPLACE.md](docs/INTEGRATIONS_MARKETPLACE.md)** - Integration platform
283283
- **[RESOURCE_SEEDING_INSTRUCTIONS.md](docs/RESOURCE_SEEDING_INSTRUCTIONS.md)** - Seed data guide
284+
- **[CICD_DEPLOYMENT_PLAN.md](docs/CICD_DEPLOYMENT_PLAN.md)** - CI/CD pipeline and Docker deployment
284285
- **[CLAUDE.md](docs/CLAUDE.md)** - AI assistant guide for this codebase
285286

286287
## 🛠️ Development
@@ -362,17 +363,26 @@ useEffect(() => {
362363

363364
## 📦 Deployment
364365

365-
### Lovable Platform
366+
| Environment | Platform | Details |
367+
|-------------|----------|---------|
368+
| **Development** | [Lovable](https://lovable.dev/projects/aaa3208a-70fb-4eb6-a5eb-5823f025e734) | Auto-syncs with GitHub |
369+
| **Production** | Docker on Hetzner | EU-hosted, fixed costs |
370+
| **Local/On-Premise** | Docker | Same image, custom Supabase |
366371

367-
The project is deployed via [Lovable](https://lovable.dev/projects/aaa3208a-70fb-4eb6-a5eb-5823f025e734).
372+
### CI/CD Pipeline
368373

369-
To deploy updates: **Share → Publish**
374+
- **PRs**: Automated lint, type-check, build, test
375+
- **Releases**: Manual workflow with migrations and Edge Functions deployment
376+
- **Docker Images**: Published to GitHub Container Registry (GHCR)
370377

371-
### Custom Domain
378+
See **[docs/CICD_DEPLOYMENT_PLAN.md](docs/CICD_DEPLOYMENT_PLAN.md)** for full setup instructions.
372379

373-
Navigate to **Project > Settings > Domains** and click **Connect Domain**.
380+
### Quick Docker Run
374381

375-
Read more: [Setting up a custom domain](https://docs.lovable.dev/features/custom-domain)
382+
```bash
383+
docker pull ghcr.io/sheetmetalconnect/eryxon-flow:latest
384+
docker run -p 8080:80 ghcr.io/sheetmetalconnect/eryxon-flow:latest
385+
```
376386

377387
## 🧪 Testing
378388

0 commit comments

Comments
 (0)