Skip to content

Commit c6d31d1

Browse files
committed
fix: review and improve CI/CD setup
- ci.yml: Remove dev branch reference (using Lovable for dev) - ci.yml: Use PROD secrets for build verification - Dockerfile: Add ENV declarations so Vite picks up build args - README: Add CI/CD section with deployment environments table - README: Link to CICD_DEPLOYMENT_PLAN.md in documentation list
1 parent bccaece commit c6d31d1

File tree

3 files changed

+28
-8
lines changed

3 files changed

+28
-8
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: CI
22

33
on:
44
pull_request:
5-
branches: [main, dev]
5+
branches: [main]
66

77
jobs:
88
lint-and-typecheck:
@@ -45,8 +45,8 @@ jobs:
4545
- name: Build
4646
run: npm run build
4747
env:
48-
VITE_SUPABASE_URL: ${{ secrets.VITE_SUPABASE_URL_DEV }}
49-
VITE_SUPABASE_PUBLISHABLE_KEY: ${{ secrets.VITE_SUPABASE_ANON_KEY_DEV }}
48+
VITE_SUPABASE_URL: ${{ secrets.VITE_SUPABASE_URL_PROD }}
49+
VITE_SUPABASE_PUBLISHABLE_KEY: ${{ secrets.VITE_SUPABASE_ANON_KEY_PROD }}
5050

5151
test:
5252
name: Test

Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ COPY . .
1616
ARG VITE_SUPABASE_URL
1717
ARG VITE_SUPABASE_PUBLISHABLE_KEY
1818

19+
# Set as environment variables for Vite build
20+
ENV VITE_SUPABASE_URL=$VITE_SUPABASE_URL
21+
ENV VITE_SUPABASE_PUBLISHABLE_KEY=$VITE_SUPABASE_PUBLISHABLE_KEY
22+
1923
# Build the app
2024
RUN npm run build
2125

README.md

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Comprehensive documentation is available in the [`/docs`](./docs) folder:
7272
- **[API_DOCUMENTATION.md](docs/API_DOCUMENTATION.md)** - REST API reference
7373
- **[DESIGN_SYSTEM.md](docs/DESIGN_SYSTEM.md)** - Design tokens and styling
7474
- **[EDGE_FUNCTIONS_SETUP.md](docs/EDGE_FUNCTIONS_SETUP.md)** - Edge Functions guide
75+
- **[CICD_DEPLOYMENT_PLAN.md](docs/CICD_DEPLOYMENT_PLAN.md)** - CI/CD pipeline and Docker deployment
7576
- **[CLAUDE.md](CLAUDE.md)** - AI assistant guide for contributors
7677

7778
Additional documentation:
@@ -117,11 +118,26 @@ Additional documentation:
117118

118119
## 📦 Deployment
119120

120-
Deployed via [Lovable Platform](https://lovable.dev/projects/aaa3208a-70fb-4eb6-a5eb-5823f025e734)
121+
| Environment | Platform | Details |
122+
|-------------|----------|---------|
123+
| **Development** | [Lovable](https://lovable.dev/projects/aaa3208a-70fb-4eb6-a5eb-5823f025e734) | Auto-syncs with GitHub |
124+
| **Production** | Docker on Hetzner | EU-hosted, fixed costs |
125+
| **Local/On-Premise** | Docker | Same image, custom Supabase |
121126

122-
To deploy updates: **Share → Publish**
127+
### CI/CD Pipeline
123128

124-
For custom domains, see [Lovable docs](https://docs.lovable.dev/features/custom-domain)
129+
- **PRs**: Automated lint, type-check, build, test
130+
- **Releases**: Manual workflow with migrations and Edge Functions deployment
131+
- **Docker Images**: Published to GitHub Container Registry (GHCR)
132+
133+
See **[docs/CICD_DEPLOYMENT_PLAN.md](docs/CICD_DEPLOYMENT_PLAN.md)** for full setup instructions.
134+
135+
### Quick Docker Run
136+
137+
```bash
138+
docker pull ghcr.io/sheetmetalconnect/eryxon-flow:latest
139+
docker run -p 8080:80 ghcr.io/sheetmetalconnect/eryxon-flow:latest
140+
```
125141

126142
## 📄 License
127143

@@ -133,6 +149,6 @@ This software is for internal use only and may not be distributed, copied, or mo
133149

134150
---
135151

136-
**Built with** React 18 + TypeScript + Supabase
137-
**Status**: Production
152+
**Built with** React 18 + TypeScript + Supabase
153+
**Status**: Production
138154
**Version**: 1.2

0 commit comments

Comments
 (0)