fix(qa): Improve connection times in regtest framework (ZcashFoundation#9917)

* reduce default `crawl_new_peer_interval`

* remove reindex test

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Author: oxarbitrage

zebra-rpc/qa/base_config.toml

@@ -6,6 +6,9 @@ listen_addr = "127.0.0.1:0"
 network = "Regtest"
 max_connections_per_ip = 10
 cache_dir = false
+crawl_new_peer_interval = "5 seconds"
+initial_mainnet_peers = []
+initial_testnet_peers = []
 
 [rpc]
 listen_addr = "127.0.0.1:0"

zebra-rpc/qa/pull-tester/rpc-tests.py

@@ -38,7 +38,6 @@
 BASE_SCRIPTS= [
     # Scripts that are run by the travis build process
     # Longest test should go first, to favor running tests in parallel
-    'reindex.py',
     'getmininginfo.py',
     'nuparams.py',
     'addnode.py',

zebra-rpc/qa/rpc-tests/addnode.py

@@ -24,29 +24,11 @@ def setup_network(self, split=False):
         connect_nodes_bi(self.nodes,1,2)
         connect_nodes_bi(self.nodes,0,2)
         self.is_network_split=split
-        self.sync_all(False)
 
         self.nodes[0].generate(1)
         self.sync_all(False)
 
     def run_test(self):
-        print("checking connections...")
-
-        # As we connected the nodes to each other, they should have,
-        # at least 4 peers. Poll for that.
-        # TODO: Move this check to its own function.
-        timeout_for_connetions = 180
-        wait_time = 1
-        while timeout_for_connetions > 0:
-            if (len(self.nodes[0].getpeerinfo()) < 4 or
-                len(self.nodes[1].getpeerinfo()) < 4 or
-                len(self.nodes[2].getpeerinfo()) < 4):
-                timeout_for_connetions -= wait_time
-                time.sleep(wait_time)
-            else:
-                break
-        assert timeout_for_connetions > 0, "Timeout waiting for connections"
-
         print("Mining blocks...")
 
         # Mine a block from node0