Remove upgrade from ansible-version

Author: Shivani-gslab

.github/workflows/pull-request-management.yml

@@ -140,7 +140,7 @@ jobs:
           - "eos_cli_config_gen_deprecated_vars"
           - "eos_cli_config_gen_negative_unit_tests"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         # Also test minimum ansible version for one scenario.
         include:
           - avd_scenario: "eos_cli_config_gen"
@@ -151,7 +151,7 @@ jobs:
       - uses: actions/checkout@v4
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status
@@ -172,14 +172,14 @@ jobs:
       fail-fast: true
       matrix:
         avd_scenario: ["dhcp_configuration", "dhcp_provisioning"]
-        ansible_version: ["ansible-core<2.19.0 --upgrade"]
+        ansible_version: ["ansible-core<2.19.0"]
     needs: [file-changes]
     if: needs.file-changes.outputs.dhcp == 'true'
     steps:
       - uses: actions/checkout@v4
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status
@@ -219,19 +219,19 @@ jobs:
           - "example-cv-pathfinder"
         ansible_version:
           # Testing all scenario with 2.16.x, due to bug with in 2.17.0 with and the way we test eos_designs_negative_unit_tests https://github.com/ansible/ansible/issues/83292
-          - "ansible-core>=2.16.0,<2.17.0 --upgrade"
+          - "ansible-core>=2.16.0,<2.17.0"
         pip_requirements:
           - ".github/requirements-ci-dev.txt"
         # Also test minimum ansible version for one scenario.
         include:
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core==2.16.0 --upgrade"
+            ansible_version: "ansible-core==2.16.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core<2.18.0 --upgrade"
+            ansible_version: "ansible-core<2.18.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
           - avd_scenario: "eos_designs_unit_tests"
-            ansible_version: "ansible-core<2.19.0 --upgrade"
+            ansible_version: "ansible-core<2.19.0"
             pip_requirements: ".github/requirements-ci-dev.txt"
     needs: [file-changes]
     if: needs.file-changes.outputs.eos_design == 'true' || needs.file-changes.outputs.config_gen == 'true'
@@ -245,7 +245,7 @@ jobs:
         if: matrix.pip_requirements == 'tmp-requirements-minimum.txt'
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status
@@ -267,7 +267,7 @@ jobs:
         avd_scenario:
           - "eos_config_deploy_cvp"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         include:
           - avd_scenario: "eos_config_deploy_cvp"
             ansible_version: "ansible-core==2.16.0"
@@ -278,7 +278,7 @@ jobs:
       - uses: actions/checkout@v4
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status
@@ -301,7 +301,7 @@ jobs:
         avd_scenario:
           - 'anta_runner'
         ansible_version:
-          - 'ansible-core<2.19.0 --upgrade'
+          - 'ansible-core<2.19.0'
         include:
           - avd_scenario: 'anta_runner'
             ansible_version: 'ansible-core==2.16.0'
@@ -311,7 +311,7 @@ jobs:
       - uses: actions/checkout@v4
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status
@@ -330,7 +330,7 @@ jobs:
         avd_scenario:
           - "eos_validate_state"
         ansible_version:
-          - "ansible-core<2.19.0 --upgrade"
+          - "ansible-core<2.19.0"
         include:
           - avd_scenario: "eos_validate_state"
             ansible_version: "ansible-core==2.16.0"
@@ -340,7 +340,7 @@ jobs:
       - uses: actions/checkout@v4
       - name: Run molecule test
         run: |
-          pip install ${{ matrix.ansible_version}} -r .github/requirements-ci-dev.txt
+          pip install "${{ matrix.ansible_version}}" -r .github/requirements-ci-dev.txt
           cd ansible_collections/arista/avd
           molecule test --scenario-name ${{ matrix.avd_scenario }}
       - name: Check GIT status