Skip to content

Commit feff859

Browse files
committed
Centralize Ruby Version to .ruby-version
The `.ruby-version` file is the ecosystem standard for defining a Ruby version. This PR adds the `.ruby-version` file, ensures a `required_ruby_version` is set, and removes all other references to Ruby in this repository, aligning it with the standard. > [!IMPORTANT] > Please verify the following before merging: Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant: - [ ] `.ruby-version` file is present with the correct Ruby version defined - [ ] A `required_ruby_version` in your gemspec is set - [ ] There is no Ruby version present in the `dev.yml` Ruby task (before: `- ruby: x.x.x`, after: `- ruby`) - [ ] There is no Ruby version/requirement referenced in the `Gemfile` (no lines with `ruby <some-version>`) - [ ] A `Gemfile.lock` is built with the defined Ruby version - [ ] The version of Rubocop installed is 1.61.0 or greater - [ ] There is no `TargetRubyVersion` defined in `rubocop.yml` (reads from `required_ruby_version` on Rubocop 1.61.0) - [ ] There is no Ruby argument present in `ruby/setup-ruby` Github Actions that do **not** run on a Ruby matrix (no lines with `ruby-version: “x.x”`) To establish consistency, the `required_ruby_version`is set to 3.0. If you think that another version is a better fit, please make the applicable changes. Please merge this PR if it looks good, this PR will be addressed if there isn't any activity after 4 weeks.
1 parent 56e384c commit feff859

File tree

5 files changed

+98
-2
lines changed

5 files changed

+98
-2
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
strategy:
2929
fail-fast: false
3030
matrix:
31-
ruby: ["3.2"]
31+
ruby: ["3.0", "3.1", "3.2", "3.3"]
3232
steps:
3333
- name: Check out code
3434
uses: actions/checkout@v4

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
.bundle
44
.config
55
.yardoc
6-
Gemfile.lock
76
InstalledFiles
87
_yardoc
98
coverage

.ruby-version

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3.3.0

Gemfile.lock

+94
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
PATH
2+
remote: .
3+
specs:
4+
activerecord-rescue_from_duplicate (0.2.6)
5+
activerecord (>= 7)
6+
7+
GEM
8+
remote: https://rubygems.org/
9+
specs:
10+
activemodel (7.1.3.2)
11+
activesupport (= 7.1.3.2)
12+
activerecord (7.1.3.2)
13+
activemodel (= 7.1.3.2)
14+
activesupport (= 7.1.3.2)
15+
timeout (>= 0.4.0)
16+
activesupport (7.1.3.2)
17+
base64
18+
bigdecimal
19+
concurrent-ruby (~> 1.0, >= 1.0.2)
20+
connection_pool (>= 2.2.5)
21+
drb
22+
i18n (>= 1.6, < 2)
23+
minitest (>= 5.1)
24+
mutex_m
25+
tzinfo (~> 2.0)
26+
base64 (0.2.0)
27+
bigdecimal (3.1.7)
28+
coderay (1.1.3)
29+
concurrent-ruby (1.2.3)
30+
connection_pool (2.4.1)
31+
diff-lcs (1.5.1)
32+
docile (1.4.0)
33+
drb (2.2.1)
34+
i18n (1.14.4)
35+
concurrent-ruby (~> 1.0)
36+
method_source (1.0.0)
37+
minitest (5.22.3)
38+
mutex_m (0.2.0)
39+
mysql2 (0.5.6)
40+
pg (1.5.6)
41+
pry (0.14.2)
42+
coderay (~> 1.1)
43+
method_source (~> 1.0)
44+
rake (13.2.0)
45+
rspec (3.13.0)
46+
rspec-core (~> 3.13.0)
47+
rspec-expectations (~> 3.13.0)
48+
rspec-mocks (~> 3.13.0)
49+
rspec-core (3.13.0)
50+
rspec-support (~> 3.13.0)
51+
rspec-expectations (3.13.0)
52+
diff-lcs (>= 1.2.0, < 2.0)
53+
rspec-support (~> 3.13.0)
54+
rspec-mocks (3.13.0)
55+
diff-lcs (>= 1.2.0, < 2.0)
56+
rspec-support (~> 3.13.0)
57+
rspec-support (3.13.1)
58+
simplecov (0.22.0)
59+
docile (~> 1.1)
60+
simplecov-html (~> 0.11)
61+
simplecov_json_formatter (~> 0.1)
62+
simplecov-html (0.12.3)
63+
simplecov_json_formatter (0.1.4)
64+
sqlite3 (1.7.3-aarch64-linux)
65+
sqlite3 (1.7.3-arm-linux)
66+
sqlite3 (1.7.3-arm64-darwin)
67+
sqlite3 (1.7.3-x86-linux)
68+
sqlite3 (1.7.3-x86_64-darwin)
69+
sqlite3 (1.7.3-x86_64-linux)
70+
timeout (0.4.1)
71+
tzinfo (2.0.6)
72+
concurrent-ruby (~> 1.0)
73+
74+
PLATFORMS
75+
aarch64-linux
76+
arm-linux
77+
arm64-darwin
78+
x86-linux
79+
x86_64-darwin
80+
x86_64-linux
81+
82+
DEPENDENCIES
83+
activerecord-rescue_from_duplicate!
84+
bundler
85+
mysql2
86+
pg
87+
pry
88+
rake
89+
rspec
90+
simplecov
91+
sqlite3
92+
93+
BUNDLED WITH
94+
2.5.3

activerecord-rescue_from_duplicate.gemspec

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Gem::Specification.new do |spec|
1313
spec.homepage = "https://github.com/Shopify/activerecord-rescue_from_duplicate"
1414
spec.license = "MIT"
1515

16+
spec.required_ruby_version = ">= 3.0"
17+
1618
spec.files = `git ls-files`.split($/)
1719
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
1820
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})

0 commit comments

Comments
 (0)