Skip to content

Add carthage support #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

breno-unspun
Copy link

What changes are you making?

Add Carthage support.

How to test

From a project that supports Carthage.
Add the following line to the Cartfile.

github "breno-unspun/checkout-sheet-kit-swift" "add-carthage-support"

I updated the README to reflect the usage once the PR is merged.


Before you merge

Important


Checklist for releasing a new version
  • I have bumped the version number in the podspec file.
  • I have bumped the version number in the README.
  • I have added a Changelog entry.

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

Add instruction to use the framework with Carthage
@breno-unspun
Copy link
Author

I have signed the CLA!

@breno-unspun breno-unspun marked this pull request as ready for review March 21, 2025 19:07
@breno-unspun breno-unspun requested a review from a team as a code owner March 21, 2025 19:07
@kieran-osgood-shopify
Copy link
Contributor

Hey @breno-unspun

We discussed internally and don't feel carthage support is something we intend to provide, given its SPM/Pods.
Appreciate you taking the time to open a PR

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants