Merge pull request #5581 from Shopify/03-28-exclude_map_files_from_the_app_bundle

Exclude map files from the app bundle

Author: gonzaloriestra

packages/app/src/cli/services/bundle.test.ts

@@ -44,4 +44,23 @@ describe('compressBundle', () => {
       expect(zipExists).toBe(true)
     })
   })
+
+  test('excludes .js.map files from the zip', async () => {
+    await inTemporaryDirectory(async (tmpDir) => {
+      // Given
+      const inputDir = joinPath(tmpDir, 'input')
+      const outputZip = joinPath(tmpDir, 'output.zip')
+      await mkdir(inputDir)
+      await writeFile(joinPath(inputDir, 'test.txt'), 'test content')
+      await writeFile(joinPath(inputDir, 'test.js.map'), 'test content')
+
+      // When
+      await compressBundle(inputDir, outputZip)
+
+      // Then
+      const zipContent = await readFile(outputZip)
+      // We are reading the zip as a binary because we don't have a library to unzip, but we can still check for the presence of the file name
+      expect(zipContent).not.toContain('test.js.map')
+    })
+  })
 })

packages/app/src/cli/services/bundle.ts

@@ -19,6 +19,7 @@ export async function compressBundle(inputPath: string, outputPath: string) {
   await zip({
     inputDirectory: inputPath,
     outputZipPath: outputPath,
+    matchFilePattern: ['**/*', '!**/*.js.map'],
   })
 }
 

packages/cli-kit/src/public/node/archiver.ts

@@ -16,9 +16,9 @@ interface ZipOptions {
   outputZipPath: string
 
   /**
-   * Pattern to match when adding files to zip, uses glob expressions.
+   * Pattern(s) to match when adding files to zip, uses glob expressions.
    */
-  matchFilePattern?: string
+  matchFilePattern?: string | string[]
 }
 
 /**