Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API version for discounts templates #418

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Update API version for discounts templates #418

merged 1 commit into from
Jan 19, 2024

Conversation

jharlap
Copy link
Contributor

@jharlap jharlap commented Jan 9, 2024

@jharlap jharlap requested a review from stefanlegg January 9, 2024 17:41
@jharlap jharlap force-pushed the api_2024-01 branch 3 times, most recently from ae7a1a0 to 55158ac Compare January 9, 2024 18:03
stefanlegg
stefanlegg reviewed Jan 9, 2024
View reviewed changes
checkout/javascript/cart-transform/default/shopify.extension.toml.liquid
@@ -1,4 +1,4 @@
api_version = "2023-10"
api_version = "2024-01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

stefanlegg
stefanlegg approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@stefanlegg stefanlegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

samihibrahim
samihibrahim approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@samihibrahim samihibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍 quick question though: How did you generate these changes?

@jharlap
Copy link
Contributor Author

jharlap commented Jan 19, 2024

Changes look good 👍 quick question though: How did you generate these changes?

Tedium 😏
For each extension type:

  1. use the Shopify CLI to generate a new extension
  2. update the API version in its toml
  3. run shopify app function schema to pull the latest
  4. manually copy the new schema over and update the toml template

@jharlap jharlap merged commit 2017f3e into main Jan 19, 2024
@jharlap jharlap deleted the api_2024-01 branch January 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanlegg stefanlegg stefanlegg approved these changes

@samihibrahim samihibrahim samihibrahim approved these changes

@nickwesselman nickwesselman Awaiting requested review from nickwesselman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jharlap @stefanlegg @samihibrahim