Skip to content

Commit de454fe

Browse files
fix(skeleton): include line item children recursively (#3753)
* fix(skeleton): include line item children recursively Rename local variable shadowing line item children to include children recursively. * feat(changeset): add changeset for skeleton changes
1 parent a810db4 commit de454fe

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

.changeset/odd-numbers-hug.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
'@shopify/cli-hydrogen': patch
3+
'@shopify/create-hydrogen': patch
4+
'skeleton': patch
5+
---
6+
7+
Include line item children recursively in cart.

templates/skeleton/app/components/CartMain.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ function getLineItemChildrenMap(lines: CartLine[]): LineItemChildrenMap {
2323
children[parentId].push(line);
2424
}
2525
if ('lineComponents' in line) {
26-
const children = getLineItemChildrenMap(line.lineComponents);
27-
for (const [parentId, childIds] of Object.entries(children)) {
26+
const lineChildren = getLineItemChildrenMap(line.lineComponents);
27+
for (const [parentId, childIds] of Object.entries(lineChildren)) {
2828
if (!children[parentId]) children[parentId] = [];
2929
children[parentId].push(...childIds);
3030
}

0 commit comments

Comments
 (0)