address comments

Author: mvallati

lib/krane/cluster_resource_discovery.rb

@@ -20,16 +20,14 @@ def crds
 
     def prunable_resources(namespaced:)
       black_list = %w(Namespace Node ControllerRevision Event Elasticsearch)
-      result = fetch_resources(namespaced: namespaced).map do |resource|
+      fetch_resources(namespaced: namespaced).map do |resource|
         next unless resource["verbs"].one? { |v| v == "delete" }
         if resource["kind"] == "Elasticsearch"
-          StatsD.client.count('elasticsearch_resource_deletion_attempt.count', 1, tags: @namespace_tags)
+          StatsD.client.count('elasticsearch_resource_deletion_attempt.count', 1, tags: namespace)
         end
         next if black_list.include?(resource["kind"])
         [resource["apigroup"], resource["version"], resource["kind"]].compact.join("/")
       end.compact
-
-      result
     end
 
     def fetch_resources(namespaced: false)

test/unit/cluster_resource_discovery_test.rb

@@ -69,7 +69,7 @@ def test_elasticsearch_statsd_count_not_emitted_when_no_elasticsearch
       crd.prunable_resources(namespaced: true)
     end
 
-    gauge_metric = metrics.find { |m| m.name == 'Krane.elasticsearch_resources.count' && m.type == :c }
-    assert_nil(gauge_metric, "Expected elasticsearch_resources.count gauge NOT to be emitted when no Elasticsearch exists")
+    count_metric = metrics.find { |m| m.name == 'Krane.elasticsearch_resource_deletion_attempt.count' && m.type == :c }
+    assert_nil(count_metric, "Expected elasticsearch_resource_deletion_attempt.count NOT to be emitted when no Elasticsearch exists")
   end
 end