Use VariableLookup
instead of dot notation in standard array filters
#1899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @ianks' suggestion (https://github.com/Shopify/liquid/pull/1869/files#r1919321969), this PR updates standard array filters to use
Liquid::VariableLookup
instead of the dot notation convention.I initially considered something similar to the usage of the
Liquid::VariableLookup
, but I noticed it would open the door to broader use cases like accessing arrays, which might not be ideal as mentioned here (#1869 (comment)).However, in the interest of consistency, we see value in evaluating this approach, which is the goal of this PR :)