Remove n+1 for Active Storage attachments (#461)

etiennebarrie · web-flow · commit 2ba7edb2dfce · 2021-07-28T12:52:32.000-04:00
diff --git a/app/models/maintenance_tasks/task_data.rb b/app/models/maintenance_tasks/task_data.rb
@@ -40,7 +40,7 @@ def find(name)
       def available_tasks
         task_names = Task.available_tasks.map(&:name)
         available_task_runs = Run.where(task_name: task_names)
-        last_runs = Run.where(
+        last_runs = Run.with_attached_csv.where(
           id: available_task_runs.select("MAX(id) as id").group(:task_name)
         )
 

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ def find(name)`
`40`	`40`	`def available_tasks`
`41`	`41`	`task_names = Task.available_tasks.map(&:name)`
`42`	`42`	`available_task_runs = Run.where(task_name: task_names)`
`43`		`- last_runs = Run.where(`
	`43`	`+ last_runs = Run.with_attached_csv.where(`
`44`	`44`	`id: available_task_runs.select("MAX(id) as id").group(:task_name)`
`45`	`45`	`)`
`46`	`46`