Merge pull request #436 from Shopify/exclude_load_paths

Exclude load paths

Author: gmcgibbon

Gemfile.lock

@@ -1,12 +1,12 @@
 PATH
   remote: .
   specs:
-    packwerk (3.2.2)
+    packwerk (3.2.3)
       activesupport (>= 6.0)
       ast
       better_html
       bundler
-      constant_resolver (>= 0.2.0)
+      constant_resolver (>= 0.3)
       parallel
       parser
       prism (>= 0.25.0)
@@ -16,92 +16,135 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (7.0.8.7)
-      actionview (= 7.0.8.7)
-      activesupport (= 7.0.8.7)
-      rack (~> 2.0, >= 2.2.4)
+    actionpack (7.2.2.1)
+      actionview (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      nokogiri (>= 1.8.5)
+      racc
+      rack (>= 2.2.4, < 3.2)
+      rack-session (>= 1.0.1)
       rack-test (>= 0.6.3)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.0, >= 1.2.0)
-    actionview (7.0.8.7)
-      activesupport (= 7.0.8.7)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+      useragent (~> 0.16)
+    actionview (7.2.2.1)
+      activesupport (= 7.2.2.1)
       builder (~> 3.1)
-      erubi (~> 1.4)
-      rails-dom-testing (~> 2.0)
-      rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    activesupport (7.0.8.7)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
+      erubi (~> 1.11)
+      rails-dom-testing (~> 2.2)
+      rails-html-sanitizer (~> 1.6)
+    activesupport (7.2.2.1)
+      base64
+      benchmark (>= 0.3)
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
-      tzinfo (~> 2.0)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
     ast (2.4.2)
+    base64 (0.2.0)
+    benchmark (0.4.0)
     better_html (2.1.1)
       actionview (>= 6.0)
       activesupport (>= 6.0)
       ast (~> 2.0)
       erubi (~> 1.4)
       parser (>= 2.4)
       smart_properties
+    bigdecimal (3.1.9)
     builder (3.3.0)
     byebug (11.1.3)
+    cgi (0.4.2)
     concurrent-ruby (1.3.5)
-    constant_resolver (0.2.0)
+    connection_pool (2.5.3)
+    constant_resolver (0.3.0)
     crass (1.0.6)
+    date (3.4.1)
+    drb (2.2.3)
+    erb (4.0.4)
+      cgi (>= 0.3.3)
     erubi (1.13.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
+    io-console (0.8.0)
+    irb (1.15.2)
+      pp (>= 0.6.0)
+      rdoc (>= 4.0.0)
+      reline (>= 0.4.2)
     json (2.7.2)
     language_server-protocol (3.17.0.3)
-    loofah (2.24.0)
+    logger (1.7.0)
+    loofah (2.24.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
     m (1.6.0)
       method_source (>= 0.6.7)
       rake (>= 0.9.2.2)
     method_source (1.1.0)
-    minitest (5.25.4)
+    minitest (5.25.5)
     minitest-focus (1.3.1)
       minitest (>= 4, < 6)
     mocha (2.5.0)
       ruby2_keywords (>= 0.0.5)
     netrc (0.11.0)
-    nokogiri (1.18.4-aarch64-linux-gnu)
+    nokogiri (1.18.8-aarch64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.4-arm64-darwin)
+    nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.4-x86_64-darwin)
+    nokogiri (1.18.8-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.4-x86_64-linux-gnu)
+    nokogiri (1.18.8-x86_64-linux-gnu)
       racc (~> 1.4)
     parallel (1.25.1)
     parser (3.3.3.0)
       ast (~> 2.4.1)
       racc
+    pp (0.6.2)
+      prettyprint
+    prettyprint (0.2.0)
     prism (0.27.0)
+    psych (5.2.6)
+      date
+      stringio
     racc (1.8.1)
-    rack (2.2.13)
+    rack (3.1.15)
+    rack-session (2.1.1)
+      base64 (>= 0.1.0)
+      rack (>= 3.0.0)
     rack-test (2.2.0)
       rack (>= 1.3)
-    rails-dom-testing (2.2.0)
+    rackup (2.2.1)
+      rack (>= 3)
+    rails-dom-testing (2.3.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
     rails-html-sanitizer (1.6.2)
       loofah (~> 2.21)
       nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
-    railties (7.0.8.7)
-      actionpack (= 7.0.8.7)
-      activesupport (= 7.0.8.7)
-      method_source
+    railties (7.2.2.1)
+      actionpack (= 7.2.2.1)
+      activesupport (= 7.2.2.1)
+      irb (~> 1.13)
+      rackup (>= 1.0.0)
       rake (>= 12.2)
-      thor (~> 1.0)
-      zeitwerk (~> 2.5)
+      thor (~> 1.0, >= 1.2.2)
+      zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.0.6)
+    rake (13.2.1)
     rbi (0.1.12)
       prism (>= 0.18.0, < 0.28)
       sorbet-runtime (>= 0.5.9204)
+    rdoc (6.14.0)
+      erb
+      psych (>= 4.0.0)
     regexp_parser (2.9.2)
+    reline (0.6.1)
+      io-console (~> 0.5)
     rexml (3.3.9)
     rubocop (1.64.1)
       json (~> 2.3)
@@ -125,22 +168,24 @@ GEM
       rubocop (>= 0.90.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
+    securerandom (0.4.1)
     smart_properties (1.17.0)
-    sorbet (0.5.11367)
-      sorbet-static (= 0.5.11367)
-    sorbet-runtime (0.5.11367)
-    sorbet-static (0.5.11367-aarch64-linux)
-    sorbet-static (0.5.11367-universal-darwin)
-    sorbet-static (0.5.11367-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11367)
-      sorbet (= 0.5.11367)
-      sorbet-runtime (= 0.5.11367)
+    sorbet (0.5.12135)
+      sorbet-static (= 0.5.12135)
+    sorbet-runtime (0.5.12135)
+    sorbet-static (0.5.12135-aarch64-linux)
+    sorbet-static (0.5.12135-universal-darwin)
+    sorbet-static (0.5.12135-x86_64-linux)
+    sorbet-static-and-runtime (0.5.12135)
+      sorbet (= 0.5.12135)
+      sorbet-runtime (= 0.5.12135)
     spoom (1.3.2)
       erubi (>= 1.10.0)
       prism (>= 0.19.0)
       sorbet-static-and-runtime (>= 0.5.10187)
       thor (>= 0.19.2)
     spring (4.0.0)
+    stringio (3.1.7)
     tapioca (0.13.3)
       bundler (>= 2.2.25)
       netrc (>= 0.11.0)
@@ -150,20 +195,22 @@ GEM
       spoom (>= 1.2.0)
       thor (>= 1.2.0)
       yard-sorbet
-    thor (1.3.1)
+    thor (1.3.2)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)
+    useragent (0.16.11)
     yard (0.9.36)
     yard-sorbet (0.8.1)
       sorbet-runtime (>= 0.5)
       yard (>= 0.9)
-    zeitwerk (2.6.4)
+    zeitwerk (2.6.18)
 
 PLATFORMS
   aarch64-linux
   arm64-darwin-21
   arm64-darwin-22
+  arm64-darwin-23
   x86_64-darwin
   x86_64-darwin-20
   x86_64-linux

lib/packwerk/application_validator.rb

@@ -72,7 +72,8 @@ def check_package_manifest_syntax(configuration)
     def check_application_structure(configuration)
       resolver = ConstantResolver.new(
         root_path: configuration.root_path.to_s,
-        load_paths: configuration.load_paths
+        load_paths: configuration.load_paths,
+        exclude: configuration.exclude,
       )
 
       begin

lib/packwerk/run_context.rb

@@ -22,6 +22,7 @@ def from_configuration(configuration)
           inflector: ActiveSupport::Inflector,
           custom_associations: configuration.custom_associations,
           associations_exclude: configuration.associations_exclude,
+          exclude: configuration.exclude,
           cache_enabled: configuration.cache_enabled?,
           cache_directory: configuration.cache_directory,
           config_path: configuration.config_path,
@@ -39,6 +40,7 @@ def from_configuration(configuration)
         package_paths: T.nilable(T.any(T::Array[String], String)),
         custom_associations: AssociationInspector::CustomAssociations,
         associations_exclude: T::Array[String],
+        exclude: T::Array[String],
         checkers: T::Array[Checker],
         cache_enabled: T::Boolean,
       ).void
@@ -52,6 +54,7 @@ def initialize(
       package_paths: nil,
       custom_associations: [],
       associations_exclude: [],
+      exclude: [],
       checkers: Checker.all,
       cache_enabled: false
     )
@@ -65,6 +68,7 @@ def initialize(
       @cache_enabled = cache_enabled
       @cache_directory = cache_directory
       @config_path = config_path
+      @exclude = exclude
 
       @file_processor = T.let(nil, T.nilable(FileProcessor))
       @context_provider = T.let(nil, T.nilable(ConstantDiscovery))
@@ -123,6 +127,7 @@ def resolver
         root_path: @root_path,
         load_paths: @load_paths,
         inflector: @inflector,
+        exclude: @exclude,
       )
     end
 

lib/packwerk/version.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Packwerk
-  VERSION = "3.2.2"
+  VERSION = "3.2.3"
 end

packwerk.gemspec

@@ -40,7 +40,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency("activesupport", ">= 6.0")
   spec.add_dependency("bundler")
-  spec.add_dependency("constant_resolver", ">= 0.2.0")
+  spec.add_dependency("constant_resolver", ">= 0.3")
   spec.add_dependency("parallel")
   spec.add_dependency("sorbet-runtime", ">= 0.5.9914")
   spec.add_dependency("zeitwerk", ">= 2.6.1")