Always use Set[Symbol] for custom associations in AssociationInspector and RunContext.

Author: rafaelfranca

lib/packwerk/association_inspector.rb

@@ -6,23 +6,21 @@ module Packwerk
   class AssociationInspector
     include ConstantNameInspector
 
-    #: type custom_associations = Array[Symbol] | Set[Symbol]
-
     RAILS_ASSOCIATIONS = [
       :belongs_to,
       :has_many,
       :has_one,
       :has_and_belongs_to_many,
-    ].to_set #: custom_associations
+    ].to_set #: Set[Symbol]
 
     #: (
     #|   inflector: singleton(ActiveSupport::Inflector),
-    #|   ?custom_associations: custom_associations,
+    #|   ?custom_associations: Set[Symbol],
     #|   ?excluded_files: Set[String]
     #| ) -> void
     def initialize(inflector:, custom_associations: Set.new, excluded_files: Set.new)
       @inflector = inflector
-      @associations = RAILS_ASSOCIATIONS + custom_associations #: custom_associations
+      @associations = RAILS_ASSOCIATIONS + custom_associations #: Set[Symbol]
       @excluded_files = excluded_files #: Set[String]
     end
 

lib/packwerk/run_context.rb

@@ -14,7 +14,7 @@ def from_configuration(configuration)
           load_paths: configuration.load_paths,
           package_paths: configuration.package_paths,
           inflector: ActiveSupport::Inflector,
-          custom_associations: configuration.custom_associations,
+          custom_associations: configuration.custom_associations.to_set,
           associations_exclude: configuration.associations_exclude,
           exclude: configuration.exclude,
           cache_enabled: configuration.cache_enabled?,
@@ -31,7 +31,7 @@ def from_configuration(configuration)
     #|   cache_directory: Pathname,
     #|   ?config_path: String?,
     #|   ?package_paths: (Array[String] | String)?,
-    #|   ?custom_associations: AssociationInspector::custom_associations,
+    #|   ?custom_associations: Set[Symbol],
     #|   ?associations_exclude: Array[String],
     #|   ?exclude: Array[String],
     #|   ?checkers: Array[Checker],
@@ -44,7 +44,7 @@ def initialize(
       cache_directory:,
       config_path: nil,
       package_paths: nil,
-      custom_associations: [],
+      custom_associations: Set.new,
       associations_exclude: [],
       exclude: [],
       checkers: Checker.all,

test/unit/packwerk/association_inspector_test.rb

@@ -12,7 +12,7 @@ class AssociationInspectorTest < Minitest::Test
 
     test "#association? understands custom associations" do
       node = parse("has_lots :order")
-      inspector = AssociationInspector.new(inflector: @inflector, custom_associations: [:has_lots])
+      inspector = AssociationInspector.new(inflector: @inflector, custom_associations: Set.new([:has_lots]))
 
       assert_equal "Order", inspector.constant_name_from_node(node, ancestors: [], relative_file: "")
     end