File tree 3 files changed +18
-6
lines changed
polaris-react/src/components/CalloutCard
3 files changed +18
-6
lines changed Original file line number Diff line number Diff line change
1
+ ---
2
+ ' @shopify/polaris ' : patch
3
+ ---
4
+
5
+ CalloutCard dismiss button improvements:
6
+
7
+ - Use tertiary button variant
8
+ - Use regular sized X icon
9
+ - Adjust position to match Banner
10
+ - Add translated label
Original file line number Diff line number Diff line change 35
35
}
36
36
37
37
.Dismiss {
38
- right : var (--p-space-400 );
38
+ right : var (--p-space-300 );
39
39
top : var (--p-space-400 );
40
40
position : absolute;
41
41
45
45
}
46
46
47
47
.hasDismiss {
48
- padding-right : calc (var (--p-space-800 ) + var (--p-space-200 ));
48
+ padding-right : calc (var (--p-space-800 ) + var (--p-space-300 ));
49
49
}
Original file line number Diff line number Diff line change 1
1
import React from 'react' ;
2
- import { XSmallIcon } from '@shopify/polaris-icons' ;
2
+ import { XIcon } from '@shopify/polaris-icons' ;
3
3
4
4
import { classNames } from '../../utilities/css' ;
5
+ import { useI18n } from '../../utilities/i18n' ;
5
6
import type { IconableAction } from '../../types' ;
6
7
// eslint-disable-next-line import/no-deprecated
7
8
import { LegacyCard } from '../LegacyCard' ;
@@ -37,6 +38,7 @@ export function CalloutCard({
37
38
secondaryAction,
38
39
onDismiss,
39
40
} : CalloutCardProps ) {
41
+ const i18n = useI18n ( ) ;
40
42
const primaryActionMarkup = buttonFrom ( primaryAction ) ;
41
43
const secondaryActionMarkup = secondaryAction
42
44
? buttonFrom ( secondaryAction , {
@@ -56,10 +58,10 @@ export function CalloutCard({
56
58
const dismissButton = onDismiss ? (
57
59
< div className = { styles . Dismiss } >
58
60
< Button
59
- variant = "plain "
60
- icon = { XSmallIcon }
61
+ variant = "tertiary "
62
+ icon = { XIcon }
61
63
onClick = { onDismiss }
62
- accessibilityLabel = "Dismiss card"
64
+ accessibilityLabel = { i18n . translate ( 'Polaris.Banner.dismissButton' ) }
63
65
/>
64
66
</ div >
65
67
) : null ;
You can’t perform that action at this time.
0 commit comments