Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing TextField clear button in Safari #13413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffrey-ben
Copy link

@jeffrey-ben jeffrey-ben commented Mar 20, 2025

WHY are these changes introduced?

The clear button in TextField components were not working in Safari. This bug was raised previously (issue linked below) and a fix was merged in polaris-internal.

The fix merged in polaris-internal can be seen here https://github.com/Shopify/polaris-internal/pull/895

This PR adds the same fix into the external Polaris version.

Fixes https://github.com/Shopify/merchant-to-merchant/issues/20327

How to 🎩

  1. Checkout this branch on local dev
  2. Open Storybook in Safari and navigate to the TextField > With Clear Button story
  3. Click on the clear button and the text should clear and the textfield should still remain focused.

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@jeffrey-ben jeffrey-ben self-assigned this Mar 20, 2025
@jeffrey-ben
Copy link
Author

/snapit

@jeffrey-ben jeffrey-ben marked this pull request as ready for review March 20, 2025 20:41
Copy link
Contributor

🫰✨ Thanks @jeffrey-ben! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/polaris": "0.0.0-snapshot-20250320204209"

@jeffrey-ben
Copy link
Author

👋 Tophat works great on the Polaris side - but when I update the package.json with the snapshot version in Collective, the bug persists 🤔 There's also this weird behaviour where all buttons have a red outline (?) Wondering if I am missing a step somewhere

Screenshot 2025-03-20 at 6 35 01 PM Screenshot 2025-03-20 at 6 36 27 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant