Migrate add_value command to new tool (#579)

### TL;DR
Migrated command to add new attribute value to the taxonomy from deprecated tool version to new one.

### What changed?
- Migrated `AddValueCommand` to handle value creation logic
- Added `add_value` CLI command that accepts a name and attribute friendly ID
- Added `next_id` helper method to `Value` model for ID generation
- Added `add_value` method to `Attribute` model

### How to test?
1. Run the CLI command: `bin/product_taxonomy add_value "Blueish" "color"` to add a new value to the color attribute
2. Verify the value is created with correct ID, friendly_id, and handle
3. Confirm the value appears in the appropriate data files
4. Try adding a value to an extended attribute to verify it's blocked
5. Attempt to add a duplicate value to ensure it's prevented

Sample run:
```
❯ bin/product_taxonomy add_value "Blueish" "color"
Created value `Blueish` for attribute `Color`
Dumping attributes...
Updated `/Users/danielgross/product-taxonomy/data/attributes.yml`
Dumping values...
Updated `/Users/danielgross/product-taxonomy/data/values.yml`
Syncing EN localizations
Syncing values...
Wrote values localizations to /Users/danielgross/product-taxonomy/data/localizations/values/en.yml
Version: unstable
Generating sibling groups...
Generating category search index...
Generating attributes...
Generating mappings...
Generating attributes with categories...
Generating attribute with categories search index...
Completed in 2.78 seconds
```

Author: danielpgross

dev/lib/product_taxonomy.rb

@@ -53,3 +53,4 @@ def data_path = DATA_PATH
 require_relative "product_taxonomy/commands/dump_values_command"
 require_relative "product_taxonomy/commands/sync_en_localizations_command"
 require_relative "product_taxonomy/commands/add_category_command"
+require_relative "product_taxonomy/commands/add_value_command"

dev/lib/product_taxonomy/cli.rb

@@ -67,5 +67,10 @@ def sync_en_localizations
     def add_category(name, parent_id)
       AddCategoryCommand.new(options.merge(name:, parent_id:)).run
     end
+
+    desc "add_value NAME ATTRIBUTE_FRIENDLY_ID", "Add a new value with NAME to the primary attribute with ATTRIBUTE_FRIENDLY_ID"
+    def add_value(name, attribute_friendly_id)
+      AddValueCommand.new(options.merge(name:, attribute_friendly_id:)).run
+    end
   end
 end

dev/lib/product_taxonomy/commands/add_value_command.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module ProductTaxonomy
+  class AddValueCommand < Command
+    def initialize(options)
+      super
+      load_taxonomy
+      @name = options[:name]
+      @attribute_friendly_id = options[:attribute_friendly_id]
+    end
+
+    def execute
+      create_value!
+      update_data_files!
+    end
+
+    private
+
+    def create_value!
+      @attribute = Attribute.find_by(friendly_id: @attribute_friendly_id)
+      raise "Attribute `#{@attribute_friendly_id}` not found" if @attribute.nil?
+      if @attribute.extended?
+        raise "Attribute `#{@attribute.name}` is an extended attribute, please use a primary attribute instead"
+      end
+
+      friendly_id = IdentifierFormatter.format_friendly_id("#{@attribute.friendly_id}__#{@name}")
+      value = Value.create_validate_and_add!(
+        id: Value.next_id,
+        name: @name,
+        friendly_id:,
+        handle: IdentifierFormatter.format_handle(friendly_id),
+      )
+      @attribute.add_value(value)
+
+      logger.info("Created value `#{value.name}` for attribute `#{@attribute.name}`")
+    end
+
+    def update_data_files!
+      DumpAttributesCommand.new(options).execute
+      DumpValuesCommand.new(options).execute
+      SyncEnLocalizationsCommand.new(targets: "values").execute
+      GenerateDocsCommand.new({}).execute
+
+      logger.warn(
+        "Attribute has custom sorting, please ensure your new value is in the right position in data/attributes.yml",
+      ) if @attribute.manually_sorted?
+    end
+  end
+end

dev/lib/product_taxonomy/models/attribute.rb

@@ -107,6 +107,13 @@ def add_extended_attribute(extended_attribute)
       @extended_attributes << extended_attribute
     end
 
+    # Add a value to the attribute.
+    #
+    # @param value [Value] The value to add.
+    def add_value(value)
+      @values << value
+    end
+
     # The global ID of the attribute
     #
     # @return [String]

dev/lib/product_taxonomy/models/value.rb

@@ -63,6 +63,11 @@ def all_values_sorted
           ]
         end
       end
+
+      # Get the next ID for a newly created value.
+      #
+      # @return [Integer] The next ID.
+      def next_id = (all.max_by(&:id)&.id || 0) + 1
     end
 
     validates :id, presence: true, numericality: { only_integer: true }

dev/test/commands/add_value_command_test.rb

@@ -0,0 +1,144 @@
+# frozen_string_literal: true
+
+require "test_helper"
+
+module ProductTaxonomy
+  class AddValueCommandTest < TestCase
+    setup do
+      @attribute = Attribute.new(
+        id: 1,
+        name: "Color",
+        description: "Defines the primary color or pattern",
+        friendly_id: "color",
+        handle: "color",
+        values: []
+      )
+      @extended_attribute = ExtendedAttribute.new(
+        name: "Clothing Color",
+        description: "Color of the clothing",
+        friendly_id: "clothing_color",
+        handle: "clothing_color",
+        values_from: @attribute
+      )
+      @existing_value = Value.new(
+        id: 1,
+        name: "Black",
+        friendly_id: "color__black",
+        handle: "color__black"
+      )
+      @attribute.add_value(@existing_value)
+
+      Attribute.add(@attribute)
+      Attribute.add(@extended_attribute)
+      Value.add(@existing_value)
+
+      AddValueCommand.any_instance.stubs(:load_taxonomy)
+      DumpAttributesCommand.any_instance.stubs(:load_taxonomy)
+      DumpValuesCommand.any_instance.stubs(:load_taxonomy)
+      SyncEnLocalizationsCommand.any_instance.stubs(:load_taxonomy)
+      GenerateDocsCommand.any_instance.stubs(:load_taxonomy)
+    end
+
+    test "execute successfully adds a new value to an attribute" do
+      DumpAttributesCommand.any_instance.expects(:execute).once
+      DumpValuesCommand.any_instance.expects(:execute).once
+      SyncEnLocalizationsCommand.any_instance.expects(:execute).once
+      GenerateDocsCommand.any_instance.expects(:execute).once
+
+      AddValueCommand.new(name: "Blue", attribute_friendly_id: "color").execute
+
+      new_value = @attribute.values.find { |v| v.name == "Blue" }
+      assert_not_nil new_value
+      assert_equal 2, new_value.id  # Since id 1 already exists
+      assert_equal "Blue", new_value.name
+      assert_equal "color__blue", new_value.friendly_id
+      assert_equal "color__blue", new_value.handle
+      assert_not_nil Value.find_by(friendly_id: "color__blue")
+    end
+
+    test "execute raises error when attribute not found" do
+      assert_raises(RuntimeError) do
+        AddValueCommand.new(name: "Blue", attribute_friendly_id: "nonexistent").execute
+      end
+    end
+
+    test "execute raises error when trying to add value to extended attribute" do
+      assert_raises(RuntimeError) do
+        AddValueCommand.new(name: "Blue", attribute_friendly_id: "clothing_color").execute
+      end
+    end
+
+    test "execute raises error when value already exists" do
+      assert_raises(ActiveModel::ValidationError) do
+        AddValueCommand.new(name: "Black", attribute_friendly_id: "color").execute
+      end
+    end
+
+    test "execute warns when attribute has custom sorting" do
+      @attribute.stubs(:manually_sorted?).returns(true)
+
+      DumpAttributesCommand.any_instance.stubs(:execute)
+      DumpValuesCommand.any_instance.stubs(:execute)
+      SyncEnLocalizationsCommand.any_instance.stubs(:execute)
+      GenerateDocsCommand.any_instance.stubs(:execute)
+
+      logger = mock
+      logger.expects(:info).once
+      logger.expects(:warn).once.with(regexp_matches(/custom sorting/))
+
+      command = AddValueCommand.new(name: "Blue", attribute_friendly_id: "color")
+      command.stubs(:logger).returns(logger)
+      command.execute
+
+      new_value = @attribute.values.find { |v| v.name == "Blue" }
+      assert_not_nil new_value
+    end
+
+    test "execute generates correct friendly_id and handle" do
+      DumpAttributesCommand.any_instance.stubs(:execute)
+      DumpValuesCommand.any_instance.stubs(:execute)
+      SyncEnLocalizationsCommand.any_instance.stubs(:execute)
+      GenerateDocsCommand.any_instance.stubs(:execute)
+
+      IdentifierFormatter.expects(:format_friendly_id).with("color__Multi Word").returns("color__multi_word")
+      IdentifierFormatter.expects(:format_handle).with("color__multi_word").returns("color__multi_word")
+
+      AddValueCommand.new(name: "Multi Word", attribute_friendly_id: "color").execute
+
+      new_value = @attribute.values.find { |v| v.name == "Multi Word" }
+      assert_not_nil new_value
+      assert_equal "color__multi_word", new_value.friendly_id
+      assert_equal "color__multi_word", new_value.handle
+    end
+
+    test "execute calls update_data_files! with correct options" do
+      options = { name: "Blue", attribute_friendly_id: "color" }
+
+      DumpAttributesCommand.expects(:new).with(options).returns(stub(execute: true))
+      DumpValuesCommand.expects(:new).with(options).returns(stub(execute: true))
+      SyncEnLocalizationsCommand.expects(:new).with(targets: "values").returns(stub(execute: true))
+      GenerateDocsCommand.expects(:new).with({}).returns(stub(execute: true))
+
+      AddValueCommand.new(options).execute
+    end
+
+    test "execute assigns sequential IDs correctly" do
+      DumpAttributesCommand.any_instance.stubs(:execute)
+      DumpValuesCommand.any_instance.stubs(:execute)
+      SyncEnLocalizationsCommand.any_instance.stubs(:execute)
+      GenerateDocsCommand.any_instance.stubs(:execute)
+
+      AddValueCommand.new(name: "Blue", attribute_friendly_id: "color").execute
+      AddValueCommand.new(name: "Green", attribute_friendly_id: "color").execute
+
+      new_values = @attribute.values.select { |v| v.name != "Black" }.sort_by(&:id)
+      assert_equal 2, new_values.size
+      assert_equal 2, new_values[0].id
+      assert_equal 3, new_values[1].id
+      assert_equal "Blue", new_values[0].name
+      assert_equal "Green", new_values[1].name
+      assert_not_nil Value.find_by(friendly_id: "color__blue")
+      assert_not_nil Value.find_by(friendly_id: "color__green")
+    end
+  end
+end

dev/test/models/value_test.rb

@@ -213,6 +213,32 @@ class ValueTest < TestCase
       assert_equal ["Animal", "Rayé", "Autre"], sorted_values.map { _1.name(locale: "fr") }
     end
 
+    test "next_id returns 1 when there are no values" do
+      Value.reset
+      assert_equal 1, Value.next_id
+    end
+
+    test "next_id returns max id + 1 when there are existing values" do
+      Value.reset
+      Value.add(Value.new(id: 5, name: "Red", friendly_id: "color__red", handle: "color__red"))
+      Value.add(Value.new(id: 10, name: "Blue", friendly_id: "color__blue", handle: "color__blue"))
+      Value.add(Value.new(id: 3, name: "Green", friendly_id: "color__green", handle: "color__green"))
+
+      assert_equal 11, Value.next_id
+    end
+
+    test "next_id returns correct value after values have been reset" do
+      Value.reset
+      Value.add(Value.new(id: 5, name: "Red", friendly_id: "color__red", handle: "color__red"))
+      assert_equal 6, Value.next_id
+
+      Value.reset
+      assert_equal 1, Value.next_id
+
+      Value.add(Value.new(id: 3, name: "Blue", friendly_id: "color__blue", handle: "color__blue"))
+      assert_equal 4, Value.next_id
+    end
+
     private
 
     def stub_localizations